-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCProtoToJaegerProto appends parent to the end of references, parent should be first #840
Comments
@dmitryax is this related to what you found recently? |
@tigrannajaryan yes, this is related, but a bit different issue. It makes sense to put parent as the first reference in the list. I'll apply it in the the new jaeger exporter. |
Thanks for taking this on, I have another more general issue open-telemetry/opentelemetry-specification#562 that might be of interest as this translation work continues. |
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this issue
Nov 11, 2021
…#840) * Update Process() * Checkpoint * Add subtractor; fix test * Fix all simple integrator tests * Build the rest (checkpoint) * Pass all but Prometheus tests * Precommit pass * Add aggregation.Kind argument to ExportKindFor * Remove Subtractor support * Remove dead test code * Restore the Subtractor code * Fix the tests * Comments * Add tests for MetricKind * Add ChangeSign test * Test ExportKind * New file * Rename ChangeSign * Remove a TODO, add a TODO * Remove Stateful remnants * Typo * Typo * Test an invalid export kind * Comments * Lint * Apply suggestions from code review Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this issue
Nov 11, 2021
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this issue
Apr 27, 2023
…y#840) Bumps [boto3](https://github.com/boto/boto3) from 1.18.60 to 1.18.61. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.18.60...1.18.61) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this issue
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This block runs after the references list is put together: https://github.com/open-telemetry/opentelemetry-collector/blob/v0.3.0/translator/trace/jaeger/protospan_to_jaegerproto.go#L490-L501
Jaeger UI assumes the parent is the first reference and has no parent span ID in its object model, so it renders the trace incorrectly. This was encountered when trying to resolve jaegertracing/jaeger-client-java#705. My setup is jaeger thrift http -> otel-collector -> jaeger grpc -> jaeger.
The text was updated successfully, but these errors were encountered: