Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split core into more granular modules: config #7895

Closed
Tracked by #7054
codeboten opened this issue Jun 14, 2023 · 3 comments · Fixed by #7897 or #7921
Closed
Tracked by #7054

Split core into more granular modules: config #7895

codeboten opened this issue Jun 14, 2023 · 3 comments · Fixed by #7897 or #7921
Assignees

Comments

@codeboten
Copy link
Contributor

No description provided.

@codeboten codeboten changed the title config Split core into more granular modules: config Jun 14, 2023
@codeboten codeboten self-assigned this Jun 14, 2023
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 14, 2023
Fixes open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 14, 2023
Fixes open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten
Copy link
Contributor Author

For the config, i think it makes sense for each directory under config (ie. configgrpc, confighttp) to be separate modules. I'll open a few PRs for separate modules and if there's any feedback against this, we can always go w/ the full config module, but if possible i'd rather keep each package small. The only shared code i've come across thus far has been the warning method in config/internal, but for now I propose duplicating the code in the two places using it since it's pretty minimal code

@mx-psi
Copy link
Member

mx-psi commented Jun 15, 2023

From private convo, we can avoid duplicating code by using a module that has internal in its path, like opentelemetry-go does here: https://github.com/open-telemetry/opentelemetry-go/blob/b757c7083baeece1be36caa4b1c102a3ddcdfa4b/exporters/otlp/otlpmetric/go.mod#L9

codeboten pushed a commit that referenced this issue Jun 15, 2023
Fixes #7895

---------

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten reopened this Jun 15, 2023
@codeboten
Copy link
Contributor Author

Closed the wrong issue by accident

codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 15, 2023
Part of open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 15, 2023
Part of open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 15, 2023
Part of open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 15, 2023
Linked issue open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 15, 2023
Linked issue open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 15, 2023
Part of open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 15, 2023
Linked issue open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 15, 2023
Linked issue open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 15, 2023
Part of open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 15, 2023
Part of open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 15, 2023
Part of open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 15, 2023
Linked issue open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 15, 2023
Linked issue open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 15, 2023
Part of open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 15, 2023
Part of open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 15, 2023
Linked issue: open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 15, 2023
Linked issue: open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit that referenced this issue Jun 16, 2023
Part of #7895

---------

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 16, 2023
Linked issue open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 16, 2023
Linked issue open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit that referenced this issue Jun 16, 2023
Part of
#7895

Follow up to
#7904

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 16, 2023
Linked issue open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit that referenced this issue Jun 16, 2023
Part of #7895 

---------

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 16, 2023
Part of open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit that referenced this issue Jun 16, 2023
Part of #7895 

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 16, 2023
Part of open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 16, 2023
Part of open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit that referenced this issue Jun 16, 2023
Part of #7895 

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 16, 2023
Linked issue: open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 16, 2023
These are the last of the config packages. Fixes open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 16, 2023
These are the last of the config packages. Fixes open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit that referenced this issue Jun 16, 2023
Linked issue #7895

---------

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 16, 2023
These are the last of the config packages. Fixes open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jun 16, 2023
These are the last of the config packages. Fixes open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit that referenced this issue Jun 17, 2023
These are the last of the config packages. Fixes
#7895

I decided to submit these last 3 modules together to reduce review
cycles. The use of the `internal` module is a result of the conversation
w/ @mx-psi here:
#7895 (comment)

---------

Signed-off-by: Alex Boten <aboten@lightstep.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants