Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move storage extension to core #3424

Closed
pmm-sumo opened this issue Jun 11, 2021 · 1 comment
Closed

Move storage extension to core #3424

pmm-sumo opened this issue Jun 11, 2021 · 1 comment

Comments

@pmm-sumo
Copy link
Contributor

Is your feature request related to a problem? Please describe.
OpenTelemetry Collector Contrib includes a storage extension, which is currently used by filelogreceiver.

It was identified that the extension could be useful for other purposes, such as persistent buffering (#2285)

First, we can start with moving the interface and eventually the extension code could be fully moved
@pmm-sumo pmm-sumo mentioned this issue Jun 11, 2021
Merged
tigrannajaryan pushed a commit that referenced this issue Aug 4, 2021
@pmm-sumo
Copy contrib's storage interface to core (#3425)
999f565 
As discussed during the SIG, we want to move storage extension to core, starting with the interface (this PR) so persistent buffer implementation (#2285) could use it

**Link to tracking Issue:** #3424 

**Testing:** Just the interface, no tests

**Documentation:** README.md with API

cc @djaglowski @tigrannajaryan
@bogdandrutu
Copy link
Member

This is done correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bogdandrutu @pmm-sumo