Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add factory and new-style config for Prometheus receiver #33

Closed
tigrannajaryan opened this issue Jun 21, 2019 · 0 comments
Closed

Add factory and new-style config for Prometheus receiver #33

tigrannajaryan opened this issue Jun 21, 2019 · 0 comments
Assignees
Milestone

Comments

@tigrannajaryan
Copy link
Member

See Jaeger receiver factory.go and config.go as an example.

tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jun 21, 2019
This is part of remaining migration to new configuration format.

Github issue: open-telemetry#33

Testing done: make
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jun 21, 2019
This is part of remaining migration to new configuration format.

Github issue: open-telemetry#33

Testing done: make
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jun 21, 2019
This is part of remaining migration to new configuration format.

Github issue: open-telemetry#33

Testing done: make
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jun 21, 2019
This is part of remaining migration to new configuration format.

Github issue: open-telemetry#33

Testing done: make
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jun 21, 2019
This is part of remaining migration to new configuration format.

Github issue: open-telemetry#33

Testing done: make
tigrannajaryan added a commit that referenced this issue Jun 21, 2019
This is part of remaining migration to new configuration format.

Github issue: #33

Testing done: make
pjanotti referenced this issue in pjanotti/opentelemetry-service Jun 27, 2019
Firstly removing vendor/ and dep
which will be followed up by a change
switching to using modules. For now
this change enables Travis CI to build.
Could have actually just updated dependencies
using dep but that'd be an extra change and
we are already revamping this repository.

Also while here fix Stackdriver import path:
This is necessary to change to be bundled with removing
dep so that Travis CI can build as the Stackdriver
exporter was migrated to:
    "contrib.go.opencensus.io/exporter/stackdriver"

Updates #33
pjanotti referenced this issue in pjanotti/opentelemetry-service Jun 27, 2019
This change is the final half to supplement
PR #40 which removed vendoring by dep. This
now uses `go mod`.

Fixes #33
@flands flands added this to the 0.1.0 milestone Jun 28, 2019
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
Since these methods are about the span itself rather than specifically
*events* on the span, it makes sense to drop "events" from their names.

[Closes open-telemetry#33]
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this issue Oct 9, 2024
Following the 0.20.0 release from a week ago.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants