Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename service.Application to service.Server #3175

Closed
rakyll opened this issue May 13, 2021 · 5 comments
Closed

Rename service.Application to service.Server #3175

rakyll opened this issue May 13, 2021 · 5 comments
Assignees
@eddyleelin
Labels
bug Something isn't working good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up release:required-for-ga Must be resolved before GA release
Milestone
Phase2-Trace-GA-R...

Comments

@rakyll
Copy link
Contributor

rakyll commented May 13, 2021

The collector service server is currently named Application. In Otel, "application" has a significance to refer to the user applications to instrument. We might rename it to Server which would be more representative.
@rakyll rakyll added the bug Something isn't working label May 13, 2021
@rakyll
Copy link
Contributor Author

rakyll commented May 13, 2021

Or why don't we call it Collector?

@eddyleelin
Copy link
Contributor

eddyleelin commented May 16, 2021 •
edited
Loading

Sorry for the newbie question, but would this be a breaking fix? Would the changes be simply renaming the service.Application file and its variables, as well as everywhere that calls it, or are there any outside dependencies?

@bogdandrutu bogdandrutu added this to the Phase2-GA-Roadmap milestone May 17, 2021
@bogdandrutu
Copy link
Member

@eddyleelin it is, but we are allowed to do that in order to cleanup the code in this phase of the project.

@eddyleelin
Copy link
Contributor

Great! Thanks for the response. I could try to take this one on then! @bogdandrutu

@alolita alolita added the release:required-for-ga Must be resolved before GA release label May 18, 2021
@bogdandrutu bogdandrutu added good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up labels May 18, 2021
This was referenced May 20, 2021
Closed
Closed
Merged
This was referenced May 28, 2021
Closed
Closed
@bogdandrutu
Copy link
Member

We renamed to service.Collector.

@rakyll rakyll mentioned this issue Jul 8, 2021
Merged
bogdandrutu pushed a commit that referenced this issue Jul 8, 2021
@rakyll
Cleanup to remove the mentions of application (#3581)
1cfd5ef 
A follow up to #3175.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddyleelin eddyleelin

Labels
bug Something isn't working good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up release:required-for-ga Must be resolved before GA release
Projects
None yet
Milestone
Phase2-Trace-GA-Roadmap
Development

No branches or pull requests
4 participants
@rakyll @bogdandrutu @alolita @eddyleelin