Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Jaeger-related code into shared library #3168

Closed
yurishkuro opened this issue May 13, 2021 · 2 comments
Closed

Extract Jaeger-related code into shared library #3168

yurishkuro opened this issue May 13, 2021 · 2 comments

Comments

@yurishkuro
Copy link
Member

Is your feature request related to a problem? Please describe.

Both OTEL Collector and Jaeger want to import some pieces of each other's code, which doesn't work well.

  • OTEL Collector wants to support existing Jaeger SDKs by accepting Jaeger data formats
  • Jaeger backend wants to support OTLP format from OTEL SDKs

Describe the solution you'd like
Move Jaeger model related code into a shared library in jaegertracing org, including:

  • UDP/thrift receivers from Jaeger
  • OTLP -> Jaeger translators from OTEL collector
    The intention is that the new library would have only dependency on the data models, not other pieces of each project, e.g. Collector APIs for receivers / exporters won't be in the library and will have some adapters in the Collector code.

Describe alternatives you've considered
Currently OTEL Collector imports Jaeger backend code. Jaeger tried importing Collector code, but that leads to circular imports and is very difficult to manage.

Any open questions?
I'd like to hear thoughts from Collector maintainers since I am not deeply familiar with Collector code base.

@tigrannajaryan
Copy link
Member

I think this is a good idea and should be doable once #3104 is done.

/cc @bogdandrutu another reason why extracting pdata is a good idea :-)

@bogdandrutu
Copy link
Member

bogdandrutu commented Aug 27, 2021

Done. Libraries are in contrib, @yurishkuro now the problem is the "jaeger/model" that we depend on :) jaegertracing/jaeger#3217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants