-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract github.com/jaegertracing/jaeger/model as a separate module #3217
Comments
@bogdandrutu aside from some convenience functions, |
Because you have manually written classes for example |
We do, but the otel-collector does not need the functionality in those classes. In fact, those classes tie the implementation to a particular version of proto & gogo and are not compatible with the latest proto. |
we done our part, but we would still prefer to not have to depend on the entire repo just for the conversion part. Also we want to support thrift (and is in the same package). Would be a huge help for us to have that module independent. |
@bogdandrutu could you please point to the code that depends on jaeger/model? |
In opentelemetry-collector we need this dependency because we need to accept data in Jaeger proto and convert them to/from collector pdata model.
Would be amazing to reduce dependencies on our side and depend only on the jaeger/model module.
The text was updated successfully, but these errors were encountered: