Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract github.com/jaegertracing/jaeger/model as a separate module #3217

Open
bogdandrutu opened this issue Aug 18, 2021 · 5 comments
Open

Comments

@bogdandrutu
Copy link

In opentelemetry-collector we need this dependency because we need to accept data in Jaeger proto and convert them to/from collector pdata model.

Would be amazing to reduce dependencies on our side and depend only on the jaeger/model module.

@yurishkuro
Copy link
Member

@bogdandrutu aside from some convenience functions, /model is just auto-generated classes from proto. I don' think that warrants a cross-dependency, why not just re-generate them in the collector?

@bogdandrutu
Copy link
Author

Because you have manually written classes for example TraceId.

@yurishkuro
Copy link
Member

We do, but the otel-collector does not need the functionality in those classes. In fact, those classes tie the implementation to a particular version of proto & gogo and are not compatible with the latest proto.

@bogdandrutu
Copy link
Author

we done our part, but we would still prefer to not have to depend on the entire repo just for the conversion part. Also we want to support thrift (and is in the same package).

Would be a huge help for us to have that module independent.

@yurishkuro
Copy link
Member

@bogdandrutu could you please point to the code that depends on jaeger/model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants