Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid exposing publicly constants in obsreport_exporter.go #2641

Closed
bogdandrutu opened this issue Mar 9, 2021 · 7 comments
Closed

Avoid exposing publicly constants in obsreport_exporter.go #2641

bogdandrutu opened this issue Mar 9, 2021 · 7 comments
Assignees
Labels
area:miscellaneous good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up release:required-for-ga Must be resolved before GA release

Comments

@bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu added help wanted Good issue for contributors to OpenTelemetry Service to pick up good first issue Good for newcomers area:miscellaneous labels Mar 9, 2021
@gunturaf
Copy link

@bogdandrutu so the constants here

const (
// Key used to identify exporters in metrics and traces.
ExporterKey = "exporter"
// Key used to track spans sent by exporters.
SentSpansKey = "sent_spans"
// Key used to track spans that failed to be sent by exporters.
FailedToSendSpansKey = "send_failed_spans"
// Key used to track metric points sent by exporters.
SentMetricPointsKey = "sent_metric_points"
// Key used to track metric points that failed to be sent by exporters.
FailedToSendMetricPointsKey = "send_failed_metric_points"
// Key used to track logs sent by exporters.
SentLogRecordsKey = "sent_log_records"
// Key used to track logs that failed to be sent by exporters.
FailedToSendLogRecordsKey = "send_failed_log_records"
)

should be changed to private?

@humivo
Copy link
Member

humivo commented Apr 2, 2021

Hey I can take on this issue as my first one. So all this entails is to make the constants listed above not public?

@humivo
Copy link
Member

humivo commented Apr 2, 2021

@bogdandrutu @tigrannajaryan do you mind assigning this issue to me whenever you can!

@alolita
Copy link
Member

alolita commented May 12, 2021

@bogdandrutu can you review the PRs and merge. We can then close this issue.

@alolita
Copy link
Member

alolita commented May 18, 2021

@humivo - let's sync up on completing the rest of this issue.

@humivo
Copy link
Member

humivo commented May 18, 2021

@alolita Ok will do, seems like my PR get approved

@alolita alolita added the release:required-for-ga Must be resolved before GA release label May 18, 2021
@mxiamxia
Copy link
Member

mxiamxia commented May 26, 2021

This issue is fixed by PR #3253

hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:miscellaneous good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up release:required-for-ga Must be resolved before GA release
Projects
None yet
Development

No branches or pull requests

5 participants