-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid exposing publicly constants in obsreport_exporter.go
#2641
Comments
@bogdandrutu so the constants here opentelemetry-collector/obsreport/obsreport_exporter.go Lines 27 to 45 in c7e9b68
should be changed to private? |
Hey I can take on this issue as my first one. So all this entails is to make the constants listed above not public? |
@bogdandrutu @tigrannajaryan do you mind assigning this issue to me whenever you can! |
@bogdandrutu can you review the PRs and merge. We can then close this issue. |
@humivo - let's sync up on completing the rest of this issue. |
@alolita Ok will do, seems like my PR get approved |
This issue is fixed by PR #3253 |
No description provided.
The text was updated successfully, but these errors were encountered: