Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supportability: Revisit the metrics we have #2430

Closed
jpkrohling opened this issue Feb 2, 2021 · 10 comments
Closed

Supportability: Revisit the metrics we have #2430

jpkrohling opened this issue Feb 2, 2021 · 10 comments

Comments

@jpkrohling
Copy link
Member

Context: #2098 (comment)

This issue here is to track which metrics we have in the usual case, which ones are shown when a problem happens, and what we could be having to help identify problems.

@jpkrohling
Copy link
Member Author

Please, assign this to me.

@jpkrohling
Copy link
Member Author

General metrics that every receiver/exporter should have

otelcol_receiver_accepted_spans
otelcol_receiver_refused_spans

otelcol_exporter_sent_spans
otelcol_exporter_send_failed_spans

OTLP-specific

In the receiver, the metric contains the protocol that received the batch:

otelcol_receiver_accepted_spans{receiver="otlp",service_instance_id="...",transport="grpc"} 2

No special metrics for the exporter.

Jaeger-specific

In the receiver, the metric contains the protocol that received the batch:

otelcol_receiver_accepted_spans{receiver="jaeger",service_instance_id="...",transport="udp_thrift_compact"} 2

No special metrics for the exporter.

The following can be used to check the current state of the connection to the remote Jaeger collector:

# HELP otelcol_jaegerexporter_conn_state Last connection state: 0 = Idle, 1 = Connecting, 2 = Ready, 3 = TransientFailure, 4 = Shutdown
# TYPE otelcol_jaegerexporter_conn_state gauge
otelcol_jaegerexporter_conn_state{exporter_name="jaeger",service_instance_id="..."} 2

@jpkrohling
Copy link
Member Author

I'll leave this open for further feedback, but I think this is done for now.

@bogdandrutu bogdandrutu added this to the Phase2-GA-Roadmap milestone Mar 10, 2021
tigrannajaryan pushed a commit that referenced this issue Apr 9, 2021
As part of #2430, this PR adds guidelines for component developers on how to appropriately make their components observable.

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@alolita
Copy link
Member

alolita commented May 12, 2021

@bogdandrutu can this be moved to a Phase 3 backlog which will be done post GA?

@alolita
Copy link
Member

alolita commented Jul 27, 2021

@jpkrohling what is the status on this issue? Is this done?

@jpkrohling
Copy link
Member Author

I think we can close this for now. This is blocked, as we need to adopt otel-sdk before we can start adding the required metrics to the existing components in a sustainable manner.

@jpkrohling
Copy link
Member Author

To be clear: I think we should still do it, but perhaps not for GA?

@alolita
Copy link
Member

alolita commented Sep 24, 2021

Move to post-GA backlog.

@tigrannajaryan
Copy link
Member

@jpkrohling do we assume that once this issue is resolved we will also have a guidance on how custom metrics may be emitted by components? Like for example memory_limiter may emit a metric that describes whether it is currently limiting or no.

@jpkrohling
Copy link
Member Author

I just created another issue to track that specific item: #4198.

hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
…pen-telemetry#2430)

* Bump github.com/shirou/gopsutil/v3 from 3.22.10 to 3.22.12 in /tests

Bumps [github.com/shirou/gopsutil/v3](https://github.com/shirou/gopsutil) from 3.22.10 to 3.22.12.
- [Release notes](https://github.com/shirou/gopsutil/releases)
- [Commits](shirou/gopsutil@v3.22.10...v3.22.12)

---
updated-dependencies:
- dependency-name: github.com/shirou/gopsutil/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* tidy

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Antoine Toulme <atoulme@splunk.com>
@github-actions github-actions bot added the Stale label Dec 16, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 16, 2024
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants