-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supportability: Revisit the metrics we have #2430
Comments
Please, assign this to me. |
General metrics that every receiver/exporter should have
OTLP-specificIn the receiver, the metric contains the protocol that received the batch:
No special metrics for the exporter. Jaeger-specificIn the receiver, the metric contains the protocol that received the batch:
No special metrics for the exporter. The following can be used to check the current state of the connection to the remote Jaeger collector:
|
I'll leave this open for further feedback, but I think this is done for now. |
As part of #2430, this PR adds guidelines for component developers on how to appropriately make their components observable. Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@bogdandrutu can this be moved to a Phase 3 backlog which will be done post GA? |
@jpkrohling what is the status on this issue? Is this done? |
I think we can close this for now. This is blocked, as we need to adopt otel-sdk before we can start adding the required metrics to the existing components in a sustainable manner. |
To be clear: I think we should still do it, but perhaps not for GA? |
Move to post-GA backlog. |
@jpkrohling do we assume that once this issue is resolved we will also have a guidance on how custom metrics may be emitted by components? Like for example |
I just created another issue to track that specific item: #4198. |
…pen-telemetry#2430) * Bump github.com/shirou/gopsutil/v3 from 3.22.10 to 3.22.12 in /tests Bumps [github.com/shirou/gopsutil/v3](https://github.com/shirou/gopsutil) from 3.22.10 to 3.22.12. - [Release notes](https://github.com/shirou/gopsutil/releases) - [Commits](shirou/gopsutil@v3.22.10...v3.22.12) --- updated-dependencies: - dependency-name: github.com/shirou/gopsutil/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * tidy Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Antoine Toulme <atoulme@splunk.com>
Context: #2098 (comment)
This issue here is to track which metrics we have in the usual case, which ones are shown when a problem happens, and what we could be having to help identify problems.
The text was updated successfully, but these errors were encountered: