Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return consumererror.Permanent in the Prometheus remote write exporter #1733

Closed
huyan0 opened this issue Sep 3, 2020 · 4 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@huyan0
Copy link
Member

huyan0 commented Sep 3, 2020

The Prometheus remote write exporter right now returns vanilla Go errors. This breaks the retry mechanism in the Collector. If a batch contains a metric with invalid temporailty or it gets a 400 response code from the backend, the collector will exponentially backoff and retry, getting the same error every time.

If the Prometheus remote write returns error of consumererror.Permanent type, the retry mechanism will not be triggered

cc: @bogdandrutu @alolita @huyan0

@huyan0 huyan0 added the bug Something isn't working label Sep 3, 2020
@huyan0
Copy link
Member Author

huyan0 commented Sep 3, 2020

I am working on a PR to fix this.

@amanbrar1999
Copy link
Contributor

I will pick up this issue

-cc @alolita @bogdandrutu @jmacd @tigrannajaryan

@amanbrar1999
Copy link
Contributor

amanbrar1999 commented Nov 3, 2020

This issue should be resolved from my latest PR

@tigrannajaryan you can either assign it to me or close it, Yang no longer works on this project

@andrewhsu
Copy link
Member

from the issue triage session at the collector sig, looks like this is done so closing

MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
…y#1733)

* Add SpanProcessor example for Span annotation on start

* Remove New* func to make more concise

* Add doc for AttrsFunc

* Move overview comment to top

* Update based on feedback

* Remove AttrsFunc type

* Use OnEnd to print instead of separate exporter

* Move the tracer declaration
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants