Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to indicate TLS is enabled with default settings for HTTPS clients #1602

Closed
jrcamp opened this issue Aug 19, 2020 · 2 comments
Closed

How to indicate TLS is enabled with default settings for HTTPS clients #1602

jrcamp opened this issue Aug 19, 2020 · 2 comments
Milestone

Comments

@jrcamp
Copy link
Contributor

jrcamp commented Aug 19, 2020

We still have the open issue of how to specify TLS is enabled in the case where tls_settings are not needed (ie you just want default TLS config). This is a followup to #933.

Do you do:

endpoint: https://localhost:1234
endpoint: unix+tls:///var/run/sock

I think we (@bogdandrutu and @ccaraman) started discussing it but couldn't come to a conclusion.

@tigrannajaryan tigrannajaryan added this to the Backlog milestone Sep 2, 2020
@andrewhsu
Copy link
Member

from the collector sig mtg today, closing it because this is resolved (done)

@jrcamp jrcamp changed the title TLS client config unification How to indicate TLS is enabled with default settings for clients Jan 28, 2021
@jrcamp jrcamp changed the title How to indicate TLS is enabled with default settings for clients How to indicate TLS is enabled with default settings for HTTPS clients Jan 28, 2021
@jrcamp
Copy link
Contributor Author

jrcamp commented Jan 28, 2021

Relevant part of HTTPClientSettings:

type HTTPClientSettings struct {
	// The target URL to send data to (e.g.: http://some.url:9411/v1/traces).
	Endpoint string `mapstructure:"endpoint"`

	// TLSSetting struct exposes TLS client configuration.
	TLSSetting configtls.TLSClientSetting `mapstructure:",squash"`
}

I think this is solved for HTTP clients (https has to be included as part of the endpoint). May need to figure out something else for unix sockets later but can deal with it when the need arises. @bogdandrutu do you remember these discussions? Anything else to add for this ticket?

hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants