Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Span Stats Processor #1263

Closed
ashwinidulams opened this issue Jul 6, 2020 · 3 comments
Closed

Proposal: Span Stats Processor #1263

ashwinidulams opened this issue Jul 6, 2020 · 3 comments
Labels
enhancement New feature or request help wanted Good issue for contributors to OpenTelemetry Service to pick up
Milestone

Comments

@ashwinidulams
Copy link

Span Statistics Proposal

A processor for aggregating spans to derive RED (Request, Error, Distribution) metrics across a set of dimensions (dynamic or otherwise) and exporting the results to a metrics sink (prometheus endpoint, stream etc).

Motivation

A trace contains end-to-end data about the service call chain in the context of a request/transaction. This data can be mined to derive context rich metrics that can help us identify and isolate the problem as quickly as possible. For example, span level aggregation can be used to detect any performance problems within the process boundary defined by the span.

Instead of forwarding the spans to a separate processor (stream processing application) for aggregation, a otel processor can process the spans in flight and emit RED metrics at configurable time intervals.

Proposed Configuration

processors:
  # name of the processor 
  spanstatsprocessor:
    # time window for aggregation in seconds.
    timewindowseconds: 15
    # dimensions for aggregation
    dimensions:
    - http.url
    - custom_tag1
    # sink for metrics
    sink:
      # prometheus sink with a endpoint exposed at port 24880
      prometheusport: 24880
  • I believe this processor should not be part of the core and should be in contrib repo
@bogdandrutu
Copy link
Member

Would suggest this to be a contrib feature. There are a lot of unknowns in this feature so probably better to start there, and once stable and proven functionality we can move it to core

@jmacd
Copy link
Contributor

jmacd commented Jul 10, 2020

See open-telemetry/opentelemetry-specification#657, which aims to specify conventions for this kind of processor.

@bogdandrutu bogdandrutu added this to the Backlog milestone Jul 30, 2020
@bogdandrutu bogdandrutu added the help wanted Good issue for contributors to OpenTelemetry Service to pick up label Jul 30, 2020
@jrcamp
Copy link
Contributor

jrcamp commented Jul 30, 2020

Closing since it's filed under open-telemetry/opentelemetry-collector-contrib#403 now.

@jrcamp jrcamp closed this as completed Jul 30, 2020
@andrewhsu andrewhsu added the enhancement New feature or request label Jan 6, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
…y#1263)

Bumps [boto3](https://github.com/boto/boto3) from 1.21.0 to 1.21.1.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.21.0...1.21.1)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this issue Oct 9, 2024
* [operator] bump operator version to v0.104.0

Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>

* Update operator-test.yaml

---------

Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Development

No branches or pull requests

5 participants