Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and remove processorhelper.BuildCustomMetricName #11302

Open
bogdandrutu opened this issue Sep 30, 2024 · 2 comments
Open

Deprecate and remove processorhelper.BuildCustomMetricName #11302

bogdandrutu opened this issue Sep 30, 2024 · 2 comments
Assignees
@VihasMakwana
Labels
good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up

Comments

@bogdandrutu
Copy link
Member

This helper function is no longer needed since it was replaced mostly by the mdatagen which generates canonical names,
@bogdandrutu bogdandrutu added help wanted Good issue for contributors to OpenTelemetry Service to pick up good first issue Good for newcomers labels Sep 30, 2024
@VihasMakwana
Copy link
Contributor

@bogdandrutu I can take this up. Can you assign this to me?

@VihasMakwana VihasMakwana mentioned this issue Oct 1, 2024
Merged
bogdandrutu added a commit that referenced this issue Oct 1, 2024
@VihasMakwana @bogdandrutu
[chore]: deprecate and remove BuildProcessorMetricName (#11328)
d8106f5 
This helper is no longer needed since introduction of `mdatagen`.

Relates
#11302

---------

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
@olamideTiana
Copy link
Contributor

@bogdandrutu I want to work on this please

olamideTiana added a commit to olamideTiana/opentelemetry-collector that referenced this issue Oct 3, 2024
@olamideTiana
Deprecated and remove BuildCustomMetricName open-telemetry#11302
86f3452
@olamideTiana olamideTiana mentioned this issue Oct 3, 2024
Closed
jackgopack4 pushed a commit to jackgopack4/opentelemetry-collector that referenced this issue Oct 8, 2024
@VihasMakwana @bogdandrutu @jackgopack4
[chore]: deprecate and remove BuildProcessorMetricName (open-telemetr…
def05cb 
…y#11328)

This helper is no longer needed since introduction of `mdatagen`.

Relates
open-telemetry#11302

---------

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VihasMakwana VihasMakwana

Labels
good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecated and remove BuildCustomMetricName #11302 olamideTiana/opentelemetry-collector
3 participants
@bogdandrutu @VihasMakwana @olamideTiana