-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Span flags
are not decoded
#11267
Comments
The same omission looks to exist for the opentelemetry-collector/pdata/ptrace/json.go Lines 169 to 189 in 9811830
|
MrAlias
added a commit
to MrAlias/opentelemetry-collector
that referenced
this issue
Sep 25, 2024
For both the `Span` and `SpanLink`, the current unmarshalJsoniter methods do not unmarshal the `flags` field. This updates the functionality to correctly decode these values into the destination. Fix open-telemetry#11267
MrAlias
added a commit
to MrAlias/opentelemetry-collector
that referenced
this issue
Sep 25, 2024
For both the `Span` and `SpanLink`, the current unmarshalJsoniter methods do not unmarshal the `flags` field. This updates the functionality to correctly decode these values into the destination. Fix open-telemetry#11267 Signed-off-by: Tyler Yahn <codingalias@gmail.com>
MrAlias
added a commit
to MrAlias/opentelemetry-collector
that referenced
this issue
Sep 25, 2024
For both the `Span` and `SpanLink`, the current unmarshalJsoniter methods do not unmarshal the `flags` field. This updates the functionality to correctly decode these values into the destination. Fix open-telemetry#11267 Signed-off-by: Tyler Yahn <codingalias@gmail.com>
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this issue
Oct 8, 2024
For both the `Span` and `SpanLink`, the current unmarshalJsoniter methods do not unmarshal the `flags` field. This updates the functionality to correctly decode these values into the destination. Fix open-telemetry#11267 Signed-off-by: Tyler Yahn <codingalias@gmail.com> --------- Signed-off-by: Tyler Yahn <codingalias@gmail.com> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When decoding OTLP data encoded as JSON, the
Span.Flags
field is not decoded.It looks to be a missing case statement here:
opentelemetry-collector/pdata/ptrace/json.go
Lines 98 to 151 in 9811830
The text was updated successfully, but these errors were encountered: