Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TemporalityPreference / DefaultHistogramAggregation are ignored #10745

Closed
pirgeo opened this issue Jul 30, 2024 · 2 comments · Fixed by #10796
Closed

TemporalityPreference / DefaultHistogramAggregation are ignored #10745

pirgeo opened this issue Jul 30, 2024 · 2 comments · Fixed by #10796
Labels
bug Something isn't working priority:p2 Medium

Comments

@pirgeo
Copy link
Member

pirgeo commented Jul 30, 2024

I recently tried configuring the OTLP exporter for internal telemetry in the OpenTelemetry collector. While doing that, I tried to set the TemporalityPreference for the exported telemetry, which is passed through to the initOTLPHTTPExporter and initOTLPgRPCExporter methods. However, when looking through the code, it seems like TemporalityPreference and DefaultHistogramAggregation are not converted to options to be passed on to the creation of the metrics exporter (https://github.com/open-telemetry/opentelemetry-collector/blob/main/service/internal/proctelemetry/config.go#L264, I assume this is where it would go). Also, setting these options does not affect the telemetry that the collector emits at all.

Is your feature request related to a problem? Please describe.
TemporalityPreference and DefaultHistogramAggregation can't be set on the internal telemetry exporters.

Describe the solution you'd like
temporality_preference and default_histogram_aggregation are passed to the exporter. I have created a branch but am unsure if this is how it's supposed to be done (using the metricdata package directly). I am happy to open a PR or hand off the code if you think this is the right approach.

@mx-psi mx-psi added this to the Self observability milestone Jul 30, 2024
@mx-psi mx-psi added bug Something isn't working priority:p2 Medium labels Jul 30, 2024
@codeboten
Copy link
Contributor

Thanks @pirgeo, feel free to open a PR to add the feature. I've opened a similar PR in the go contrib repo to add it to the config package as well open-telemetry/opentelemetry-go-contrib#5860

@pirgeo
Copy link
Member Author

pirgeo commented Jul 31, 2024

Thanks, I might steal copy your tests :)

codeboten added a commit that referenced this issue Aug 6, 2024
#### Description
adds temporality preference option for internal telemetry exported via
OTLP

#### Link to tracking issue
(partly) fixes #10745

#### Testing
unit tests

#### Documentation
Feature is already documented, but not implemented yet.

---------

Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:p2 Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants