Add createNodeAndResource unit test

receiver/prometheusreceiver/internal/prom_to_otlp_test.go

@@ -20,19 +20,18 @@ import (
 	metricspb "github.com/census-instrumentation/opencensus-proto/gen-go/metrics/v1"
 	"github.com/stretchr/testify/require"
 
+	"go.opentelemetry.io/collector/consumer/pdata"
 	"go.opentelemetry.io/collector/translator/internaldata"
 )
 
 // Parity test to ensure that createNodeAndResource produces identical results to createNodeAndResourcePdata.
 func TestCreateNodeAndResourceEquivalence(t *testing.T) {
 	job, instance, scheme := "converter", "ocmetrics", "http"
 	ocNode, ocResource := createNodeAndResource(job, instance, scheme)
-	mdFromOC := internaldata.OCToMetrics(internaldata.MetricsData{
-		Node:     ocNode,
-		Resource: ocResource,
+	mdFromOC := internaldata.OCToMetrics(ocNode, ocResource,
 		// We need to pass in a dummy set of metrics
 		// just to populate and allow for full conversion.
-		Metrics: []*metricspb.Metric{
+		[]*metricspb.Metric{
 			{
 				MetricDescriptor: &metricspb.MetricDescriptor{
 					Name:        "m1",
@@ -41,10 +40,81 @@ func TestCreateNodeAndResourceEquivalence(t *testing.T) {
 				},
 			},
 		},
-	})
+	)
 
 	fromOCResource := mdFromOC.ResourceMetrics().At(0).Resource().Attributes().Sort()
 	byDirectOTLPResource := createNodeAndResourcePdata(job, instance, scheme).Attributes().Sort()
 
 	require.Equal(t, byDirectOTLPResource, fromOCResource)
 }
+
+type jobInstanceDefinition struct {
+	job, instance, host, scheme, port string
+}
+
+func makeResourceWithJobInstanceScheme(def *jobInstanceDefinition) pdata.Resource {
+	resource := pdata.NewResource()
+	attrs := resource.Attributes()
+	// Using hardcoded values to assert on outward expectations so that
+	// when variables change, these tests will fail and we'll have reports.
+	attrs.UpsertString("service.name", def.job)
+	attrs.UpsertString("host.name", def.host)
+	attrs.UpsertString("job", def.job)
+	attrs.UpsertString("instance", def.instance)
+	attrs.UpsertString("port", def.port)
+	attrs.UpsertString("scheme", def.scheme)
+	return resource
+}
+
+func TestCreateNodeAndResourcePromToOTLP(t *testing.T) {
+	tests := []struct {
+		name, job string
+		instance  string
+		scheme    string
+		want      pdata.Resource
+	}{
+		{
+			name: "all attributes proper",
+			job:  "job", instance: "localhost:8888", scheme: "http",
+			want: makeResourceWithJobInstanceScheme(&jobInstanceDefinition{
+				"job", "localhost:8888", "localhost", "http", "8888",
+			}),
+		},
+		{
+			name: "missing port",
+			job:  "job", instance: "myinstance", scheme: "https",
+			want: makeResourceWithJobInstanceScheme(&jobInstanceDefinition{
+				"job", "myinstance", "myinstance", "https", "",
+			}),
+		},
+		{
+			name: "blank scheme",
+			job:  "job", instance: "myinstance:443", scheme: "",
+			want: makeResourceWithJobInstanceScheme(&jobInstanceDefinition{
+				"job", "myinstance:443", "myinstance", "", "443",
+			}),
+		},
+		{
+			name: "blank instance, blank scheme",
+			job:  "job", instance: "", scheme: "",
+			want: makeResourceWithJobInstanceScheme(&jobInstanceDefinition{
+				"job", "", "", "", "",
+			}),
+		},
+		{
+			name: "blank instance, non-blank scheme",
+			job:  "job", instance: "", scheme: "http",
+			want: makeResourceWithJobInstanceScheme(&jobInstanceDefinition{
+				"job", "", "", "http", "",
+			}),
+		},
+	}
+
+	for _, tt := range tests {
+		tt := tt
+		t.Run(tt.name, func(t *testing.T) {
+			got := createNodeAndResourcePdata(tt.job, tt.instance, tt.scheme)
+			require.Equal(t, got, tt.want)
+		})
+	}
+}