Remove IsNil from value structs, update accessor message

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
open-telemetry · Nov 6, 2020 · 66e95a7 · 66e95a7
1 parent 89a8653
commit 66e95a7
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 22 deletions.
diff --git a/cmd/pdatagen/internal/base_fields.go b/cmd/pdatagen/internal/base_fields.go
@@ -56,9 +56,6 @@ const accessorsMessagePtrTestTemplate = `func Test${structName}_${fieldName}(t *
 }`
 
 const accessorsMessageValueTemplate = `// ${fieldName} returns the ${lowerFieldName} associated with this ${structName}.
-// If no ${lowerFieldName} available, it creates an empty message and associates it with this ${structName}.
-//
-//  Empty initialized ${structName} will return "nil" ${returnType}.
 //
 // Important: This causes a runtime error if IsNil() returns "true".
 func (ms ${structName}) ${fieldName}() ${returnType} {

diff --git a/cmd/pdatagen/internal/base_structs.go b/cmd/pdatagen/internal/base_structs.go
@@ -368,11 +368,6 @@ func New${structName}() ${structName} {
 // Deprecated: This function will be removed soon.
 func (ms ${structName}) InitEmpty() {
 	*ms.orig = ${originName}{}
-}
-
-// Deprecated: This function will be removed soon.
-func (ms ${structName}) IsNil() bool {
-	return false
 }`
 
 const messageValueCopyToHeaderTemplate = `// CopyTo copies all properties from the current struct to the dest.

diff --git a/consumer/pdata/generated_log.go b/consumer/pdata/generated_log.go
diff --git a/consumer/pdata/generated_metrics.go b/consumer/pdata/generated_metrics.go
diff --git a/consumer/pdata/generated_resource.go b/consumer/pdata/generated_resource.go
diff --git a/consumer/pdata/generated_trace.go b/consumer/pdata/generated_trace.go