Skip to content

Commit

Permalink
Don't run contribtest on master. We only want to run it for PRs and r…
Browse files Browse the repository at this point in the history
…eleases (#2267)

We want to contribtest to run on PRs to make it clear when we are making
a breaking change. We also want to run it on release branches to prevent
making a core release when contrib is broken.

However, there is no point in running the contribtest on master branch, it does
not help and only pollutes the view with failures that are always ignored.
  • Loading branch information
tigrannajaryan authored Dec 7, 2020
1 parent 1ed32e7 commit 5cae69d
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -236,12 +236,17 @@ workflows:
jobs:
- setup-environment:
filters:
branches:
ignore: master
tags:
only: /^v[0-9]+\.[0-9]+\.[0-9]+.*/
- contribtest:
requires:
- setup-environment
filters:
branches:
# Don't run contribtest on master. We only want to run it for PRs and releases.
ignore: master
tags:
only: /^v[0-9]+\.[0-9]+\.[0-9]+.*/

Expand Down

0 comments on commit 5cae69d

Please sign in to comment.