Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS S3 Receiver to contrib distribution #698

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Add AWS S3 Receiver to contrib distribution #698

merged 3 commits into from
Oct 29, 2024

Conversation

adcharre
Copy link
Contributor

Built successfully with ocb.

@adcharre adcharre requested a review from a team as a code owner October 16, 2024 10:35
@adcharre adcharre requested a review from fatsheep9146 October 16, 2024 10:35
shrutimantri
shrutimantri reviewed Oct 19, 2024
View reviewed changes
Copy link
Contributor

@shrutimantri shrutimantri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this receiver still in development phase?

@adcharre
Copy link
Contributor Author

Isn't this receiver still in development phase?

I've just raised a PR to move this to alpha and it was suggested to also raise a PR on this repo.
open-telemetry/opentelemetry-collector-contrib#35809

@songy23
Copy link
Member

songy23 commented Oct 23, 2024

Please rebase

@adcharre
Copy link
Contributor Author

Please rebase

@songy23 - done

@mx-psi mx-psi merged commit e2e1ec2 into open-telemetry:main Oct 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrutimantri shrutimantri shrutimantri approved these changes

@atoulme atoulme atoulme approved these changes

@mx-psi mx-psi mx-psi approved these changes

@songy23 songy23 songy23 approved these changes

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 was automatically assigned from open-telemetry/collector-contrib-approvers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adcharre @songy23 @atoulme @mx-psi @shrutimantri