Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ballast extension #607

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth requested review from a team, atoulme and mx-psi July 23, 2024 22:19
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we wait for at least 1-2 releases to see if anybody complains about the metric changing?

I would also want to remove most/all mentions to the ballast extension and related options that appear in this search: https://github.com/search?q=org%3Aopen-telemetry+ballast+-repo%3Aopen-telemetry%2Fopentelemetry-collector+-repo%3Aopen-telemetry%2Fotel-arrow-collector&type=code&p=1

@TylerHelmuth
Copy link
Member Author

@mx-psi created open-telemetry/opentelemetry-collector-contrib#34683 to handle contrib. The references in operator and helm chart should stay.

@mx-psi
Copy link
Member

mx-psi commented Aug 14, 2024

Merged!

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be good to go after v0.108.0 is out or do we want this as part of that release?

@TylerHelmuth
Copy link
Member Author

I feel comfortable with it going in v0.108.0. It has been deprecated for 8 months and the helm chart has not been using it by default for almost 9 months.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I was waiting for the search index on #607 (review) to be updated, looking at the updated results I think this is good to go.

The End User Survey shows only 3 respondents using the memory ballast so the impact should be minimal https://github.com/open-telemetry/sig-end-user/blob/main/end-user-surveys/otel-collector/otel-collector-survey.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants