-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ballast extension #607
Remove ballast extension #607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we wait for at least 1-2 releases to see if anybody complains about the metric changing?
I would also want to remove most/all mentions to the ballast extension and related options that appear in this search: https://github.com/search?q=org%3Aopen-telemetry+ballast+-repo%3Aopen-telemetry%2Fopentelemetry-collector+-repo%3Aopen-telemetry%2Fotel-arrow-collector&type=code&p=1
@mx-psi created open-telemetry/opentelemetry-collector-contrib#34683 to handle contrib. The references in operator and helm chart should stay. |
Merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be good to go after v0.108.0 is out or do we want this as part of that release?
I feel comfortable with it going in v0.108.0. It has been deprecated for 8 months and the helm chart has not been using it by default for almost 9 months. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I was waiting for the search index on #607 (review) to be updated, looking at the updated results I think this is good to go.
The End User Survey shows only 3 respondents using the memory ballast so the impact should be minimal https://github.com/open-telemetry/sig-end-user/blob/main/end-user-surveys/otel-collector/otel-collector-survey.csv
Related to open-telemetry/opentelemetry-collector#8343, following the plan from open-telemetry/opentelemetry-collector#10671 (review)