Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github action cache schema #9918

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

bogdandrutu
Copy link
Member

  • There were multiple workflows with same cache key, but no dependency between them, and also caching different paths.
  • When the tests were changed to run on different go version, cache was not updated to include the version.
  • Race condition between go1.17-test/go1.18-test/lint to update the same cache key, split into 3 caches.

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested review from a team and dmitryax May 10, 2022 17:25
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 10, 2022
* There were multiple workflows with same cache key, but no dependency between them, and also caching different paths.
* When the tests were changed to run on different go version, cache was not updated to include the version.
* Race condition between go1.17-test/go1.18-test/lint to update the same cache key, split into 3 caches.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants