Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Makefile] Fix issues with common targets #9775

Merged
merged 1 commit into from
May 9, 2022

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented May 6, 2022

Resolves #9763

Summary of changes, including a few minor related issues:

  • New ALL_PKG_DIRS uses go list to find the directories corresponding to packages of the current module only.
  • ALL_SRC changed to find .go files of the current module only.
  • Fixed ALL_PKGS, which was erroring out silently because it depended on GOCMD too early.
  • Fixed root module's default make target, which only ran common for the root module. Now runs common for all modules.
  • Removed checkdoc from per-module make file, as this only needs to run at the root.

@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 6, 2022
@djaglowski
Copy link
Member Author

/easycla

@djaglowski djaglowski marked this pull request as ready for review May 6, 2022 17:47
@djaglowski djaglowski requested review from a team and codeboten May 6, 2022 17:47
@codeboten codeboten merged commit c8a5ea0 into open-telemetry:main May 9, 2022
@@ -37,7 +37,11 @@ all-modules:
@echo $(ALL_MODULES) | tr ' ' '\n' | sort

.PHONY: all
all: common gotest otelcontribcol otelcontribcol-unstable
all: all-common gotest otelcontribcol otelcontribcol-unstable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the rule between common and non-common? Should test be there as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point. It's not very consistent. I will write up a new issue to proposal guidelines on how targets should be scoped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Makefile/checklicense] Scalability limit on files to check
4 participants