-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/mongodb] Use metrics builder for resource metrics #9759
[receiver/mongodb] Use metrics builder for resource metrics #9759
Conversation
This change refactors the receiver to rely more on generated code. The only functional change: Metrics scope name is changed from `otelcol/mongodb` to `otelcol/mongodbreceiver`
Another issue uncovered after this change: #9760 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
database: | ||
description: The name of a database. | ||
type: string | ||
|
||
attributes: | ||
database: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it expected to have the attribute and resource_attribute be a duplicate of one another?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is current behavior. I submitted a separate issue to address that #9760
…emetry#9759) This change refactors the receiver to rely more on generated code. The only functional change: Metrics scope name is changed from `otelcol/mongodb` to `otelcol/mongodbreceiver`
This change refactors the receiver to rely more on generated code.
The only functional change:
Metrics scope name is changed from
otelcol/mongodb
tootelcol/mongodbreceiver