-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/nsxreceiver] Add NSX-T Metrics Receiver #9738
Merged
djaglowski
merged 55 commits into
open-telemetry:main
from
observIQ:nsxreceiver-metrics
May 13, 2022
Merged
[receiver/nsxreceiver] Add NSX-T Metrics Receiver #9738
djaglowski
merged 55 commits into
open-telemetry:main
from
observIQ:nsxreceiver-metrics
May 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor-contrib into nsxreceiver-metrics
…tor-contrib into nsxreceiver-metrics
djaglowski
reviewed
May 4, 2022
Ah, great. I was wondering when this PR would land. I'll take a look soon |
djaglowski
reviewed
May 9, 2022
dashpole
reviewed
May 10, 2022
receiver/nsxtreceiver/internal/metadata/generated_metrics_v2.go
Outdated
Show resolved
Hide resolved
receiver/nsxtreceiver/internal/metadata/generated_metrics_v2.go
Outdated
Show resolved
Hide resolved
receiver/nsxtreceiver/internal/metadata/generated_metrics_v2.go
Outdated
Show resolved
Hide resolved
dashpole
approved these changes
May 11, 2022
Noticed same CI failures for windows-msi on a couple commits in main. Don't think its related to this PR |
…tor-contrib into nsxreceiver-metrics
…tor-contrib into nsxreceiver-metrics
dashpole
approved these changes
May 12, 2022
djaglowski
reviewed
May 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but a couple minor things need to be addressed.
djaglowski
reviewed
May 12, 2022
djaglowski
reviewed
May 12, 2022
…tor-contrib into nsxreceiver-metrics
…tor-contrib into nsxreceiver-metrics
djaglowski
approved these changes
May 13, 2022
kentquirk
pushed a commit
to McSick/opentelemetry-collector-contrib
that referenced
this pull request
Jun 14, 2022
* Add new nsxtreceiver component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds a new component the nsxreceiver outlined in #9568 🚀
This component will support just the
metrics
telemetry type and sources those metrics via the NSX Rest API.Users will need permissions to read properties/statistics from the Nodes. The LPU I believe is needed is an “Auditor”
I have tested on NSX-T DataCenter 3.1.2 pretty extensively.
Decided not to use the library https://github.com/vmware/go-vmware-nsxt because it appears to be out of date with most structs only touched 5 years ago, because of this I just created API structs/imported structs that the Metric Collection requires.
Example Configuration
List of planned metrics/statistics grabbed from API
Link to tracking Issue: #9568
Testing:
Test Coverage
As of submission unit test coverage of 95.4:
Documentation:
README.md
was added along with derived metadata.yaml documentation indocumentation.md