-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/hostmetrics/process_scraper] Rename metadata conflicting wi… #8979
Conversation
…th the metrics package name Signed-off-by: Idowu Emehinola <hydeenoble39@gmail.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @hydeenoble, please sign the CLA so we can get this reviewed and merged!
Done! @codeboten |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
…th the metrics package name (open-telemetry#8979) Signed-off-by: Idowu Emehinola <hydeenoble39@gmail.com> Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
…th the metrics package name
Signed-off-by: Idowu Emehinola hydeenoble39@gmail.com
Description:
The local variable name
metadata
conflicts with the generated package name and makes this less readable. I renamedmetadata
conflicting with the metrics package name todata
Link to tracking Issue: Closes #8815
Testing:
Documentation: