Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog formatting #8849

Merged
merged 6 commits into from
Mar 30, 2022
Merged

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Mar 25, 2022

Description:

Fix changelog formatting (duplicate sections and mismatched entries).

@mx-psi mx-psi requested review from a team, bogdandrutu and jpkrohling March 25, 2022 15:07
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a missed new line

CHANGELOG.md Show resolved Hide resolved
mx-psi and others added 2 commits March 26, 2022 20:12
@tigrannajaryan
Copy link
Member

Why is not allowing to be merged? All required checks have passed.

@mx-psi
Copy link
Member Author

mx-psi commented Mar 30, 2022

Why is not allowing to be merged? All required checks have passed.

Looks like the correctness-traces job timed out and it's required https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/5744194336?check_suite_focus=true I retriggered it

@mx-psi
Copy link
Member Author

mx-psi commented Mar 30, 2022

@tigrannajaryan can you try again?

@codeboten codeboten merged commit 88c4deb into open-telemetry:main Mar 30, 2022
@mx-psi mx-psi deleted the mx-psi/fix-changelog branch March 30, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants