[receiver/awsxrayreceiver] Bugfix - Add defaults for optional stack frame parameters #8790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srprash
changed the title
Aneurysm9
approved these changes
Mar 22, 2022
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
dashpole
approved these changes
Mar 23, 2022
codeboten
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the issue where the receiver would panic while parsing the stackframe if any of the optional parameters are missing. Now before accessing these optional parameter values, they are checked and defaulted to
""if they arenil.Added a small utility function for this check.
Link to tracking Issue:
#8271
Testing:
Added new unit tests where the optional parameters were omitted. Also added unit tests for the utility function.
Documentation:
NA