[processor/resourcedetectionprocessor] Add attribute allowlist to Resource Detection Processor #8547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
requested review from
pmm-sumo,
anuraaga and
dashpole
as code owners
pmm-sumo
reviewed
Mar 17, 2022
pmm-sumo
approved these changes
Mar 17, 2022
pmm-sumo
reviewed
Mar 18, 2022
processor/resourcedetectionprocessor/internal/resourcedetection.go
Outdated
Show resolved
Hide resolved
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds to the resource detection process the ability to specify exactly which attributes should be appended to telemetry. When the new
attributesconfig is used, only attributes whose names are included in the list will be added.Link to tracking Issue:
#8242
Testing:
Unit tests and testing with local build of the collector. Updated existing unit tests to check that Detect works with the new setting. Added tests for new FilterAttributes method.
Documentation:
Updated the resource detection processor's config documentation