-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/datadog] Use exact sum and count on distributions when available #7830
Merged
jpkrohling
merged 5 commits into
open-telemetry:main
from
DataDog:mx-psi/exact-sum-count
Feb 16, 2022
Merged
[exporter/datadog] Use exact sum and count on distributions when available #7830
jpkrohling
merged 5 commits into
open-telemetry:main
from
DataDog:mx-psi/exact-sum-count
Feb 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
changed the title
[exporter/datadog] Use exact sum and count when available
[exporter/datadog] Use exact sum and count on distributions when available
Feb 11, 2022
mx-psi
commented
Feb 11, 2022
@@ -1428,5 +1428,5 @@ func TestNaNMetrics(t *testing.T) { | |||
}) | |||
|
|||
// One metric type was unknown or unsupported | |||
assert.Equal(t, observed.FilterMessage("Unsupported metric value").Len(), 6) | |||
assert.Equal(t, observed.FilterMessage("Unsupported metric value").Len(), 7) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes because before we only checked isSkippable
when send_count_sum_metrics
is enabled, while now we check it always.
KSerrania
approved these changes
Feb 14, 2022
mx-psi
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Feb 15, 2022
Marking as ready to merge since it has a CODEOWNER approval |
mx-psi
force-pushed
the
mx-psi/exact-sum-count
branch
from
February 15, 2022 10:27
dd8114b
to
e3264c5
Compare
(Rebased after #7909, no other changes) |
mx-psi
force-pushed
the
mx-psi/exact-sum-count
branch
from
February 15, 2022 14:15
a55f7be
to
b064db3
Compare
(Another |
codeboten
approved these changes
Feb 15, 2022
Merged
9 tasks
tomsanbear
pushed a commit
to tomsanbear/opentelemetry-collector-contrib
that referenced
this pull request
Mar 2, 2022
…lable (open-telemetry#7830) * [exporter/datadog] Modify sketches tests so that they only use MapMetrics * [exporter/datadog] Use exact sum, count and average on sketches * Add Changelog entry * Empty commit to re-trigger CI Co-authored-by: Alex Boten <alex@boten.ca>
jpkrohling
added a commit
that referenced
this pull request
Mar 9, 2022
* Implement new config * update readme * fix typo * update extension_test with e2e config test * add assertiont to test case * typo fix * [exporter/tanzuobservability] Turn on metrics exporter. (#7281) * [exporter/tanzuobservability] Turn on metrics exporter. * Fix misspelled type name. * Add missing comment to package statement Co-authored-by: Alex Boten <aboten@lightstep.com> * [exporter/prometheusremotewrite] Fix negative index reference to bucket list (#7306) * Fix negative index reference to bucket list * Add changelog, remove unused test input Signed-off-by: albertteoh <see.kwang.teoh@gmail.com> * [processor/attributes and resource]: Add `from_context` value source (#6987) * [attraction] Value from context Signed-off-by: Traian Schiau <traian.schiau@sap.com> * [attributesprocessor] Reword from_context description in README Signed-off-by: Traian Schiau <traian.schiau@sap.com> * [changelog] Add `from_context` value source Signed-off-by: Traian Schiau <traian.schiau@sap.com> * [exporter/dynatrace] Write error logs using plugin logger (#7360) * DT exporter error logging * Fix typo * Revert error wrapping * Update changelog * Structured logging * Review comments * Clean up zap usage * Add status to error message * [exporter/awscloudwatchlogs] Enable component (#7297) * enable awscloudwatchlogsexporter * add changelog entry for awscloudwatchlogsexporter * run gotidy * fix changelog * fix ordering of gomod * add unreleased changelog entry * fix versioning * [receiver/k8sevents] Core logic implementation (#6885) * resolved merge conflicts * resolve merge conflicts * resolved merge conflicts * resolve merge conflicts * used receiver start time to filter the events * fixed lint issue * resolve merge conflicts * Used semantic conventions and updated the code comments * added resource attributes and log attributes * changes in resource/logs attributes * updated CHANGELOG.md * Add comparison function for pdata.Metrics (#7400) The scrapertest package already provides the ability to compare pdata.MetricSlices. This PR adds comparison logic for higher level metric structs, including resources and their attributes, and their instrumentation libraries and associated fields. The PR also removes an unused pair of read/write functions in the scrapertest/golden package. These might have been useful in theory, but are much less so with the addition of direct pdata.Metrics comparisons. * [processor/resourcedetection] Config check for EKS to verify the node is on AWS (#7186) * add aws config check for eks to verify node is on aws * fix imports * fix imports * fix import order * format and add changelog * fix space * fix changelog * add debug logger * fix comment * unexport detector * fix debug message * run make gotidy * add to unreleased changelog Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> * [pkg/translator/prometheusremotewrite] Split from prometheusremotewriteexporter (#7240) * Make otlp to Prom RW conversion importable This will make it super easy for existing Remote Write compatible systems like Prometheus ingest OTLP. Now its as simple as: ``` prwe := &prometheusremotewriteexporter.PRWExporter{} tsMap, dropped, errs := prwe.ConvertMetrics(ctx, md) ``` Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Move metrics conversion to pkg/translate Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Add changelog entry Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Make lint pass Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Otel-collector-contrib-7404 passing default configurtion mount path (#7409) * [receiver/k8sevents] Change the test case name (#7419) * [receiver/jmx] Add ability to specify more jars in classpath (#7378) * Changed how jmx receiver launches JAR to use class path so additional jars can be added Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com> * Updated changelog for jmx receiver Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com> * Added appending to existing CLASSPATH env if one exists for JMX Receiver Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com> * Fixed CLASSPATH env being quoted and not finding class Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com> Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com> * Add djaglowski as codeowner of scrapertest package (#7420) * [receiver/awscontainerinsight] Add full pod name metric label (#7412) * [hostreceiver/loadscraper] Migrate the scraper to the mdatagen metrics builder (#7288) * hostreceiver/loadscraper: Migrate the scraper to the mdatagen metrics builder This change migrates hostmetrics/filesystem scraper to the new mdatagen metrics builder. There are no functional changes on the metrics output except for metrics reordering within the emitted batch. At this point, this change adds ability to disable collection of particular metrics: to be documented later. * Address review comments * Address review comments * [processor/resourcedetection] fix consul 'meta' field to allow empty values (#7424) * [processor/resourcedetection] fix consul 'meta' field to allow empty values the expected configuration for getting the 'deployment_environment' metadata key from consul is: ```yaml resourcedetection: detectors: ["system", "consul"] system: hostname_sources: ["os"] consul: meta: deployment_environment: ``` ; however, instead of checking if the 'deployment_environment' key exists in the meta labels, the detector checks if the value is non-nil which fails. * update changelog * [receiver/awsecscontainermetrics] Rename attributes to follow semantic conventions (#7425) * [receiver/awsecscontainermetrics] Add attributes following semantic conventions Old names of attributes are kept for backwards compatibility * Add changelog entry * dependabot updates Mon Jan 31 13:48:34 PST 2022 (#7505) * Generate golden results for mysql integration test (#7303) * dependabot updates Tue Feb 1 10:53:44 PST 2022 (#7519) Bump k8s.io/kubelet from 0.23.2 to 0.23.3 in /receiver/kubeletstatsreceiver Bump github.com/klauspost/compress from 1.14.1 to 1.14.2 in /exporter/honeycombexporter Bump github.com/prometheus/client_golang from 1.12.0 to 1.12.1 in /exporter/prometheusexporter Bump github.com/aws/aws-sdk-go from 1.42.40 to 1.42.44 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.42.40 to 1.42.44 in /exporter/awscloudwatchlogsexporter Bump github.com/aws/aws-sdk-go from 1.42.40 to 1.42.44 in /exporter/kafkaexporter Bump github.com/aws/aws-sdk-go from 1.42.40 to 1.42.44 in /internal/aws/proxy Bump github.com/aws/aws-sdk-go from 1.42.40 to 1.42.44 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go from 1.42.40 to 1.42.44 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.42.40 to 1.42.44 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.42.40 to 1.42.44 in /internal/aws/xray Bump github.com/aws/aws-sdk-go from 1.42.40 to 1.42.44 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go from 1.42.40 to 1.42.44 in /exporter/awsprometheusremotewriteexporter Bump github.com/aws/aws-sdk-go from 1.42.40 to 1.42.44 in /exporter/datadogexporter Bump gopkg.in/DataDog/dd-trace-go.v1 from 1.35.0 to 1.36.0 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.42.40 to 1.42.44 in /exporter/awsemfexporter Bump github.com/aws/aws-sdk-go from 1.42.40 to 1.42.44 in /processor/resourcedetectionprocessor Bump github.com/aws/aws-sdk-go from 1.42.40 to 1.42.44 in /receiver/awsxrayreceiver Bump github.com/aws/aws-sdk-go from 1.42.40 to 1.42.44 in /exporter/awsxrayexporter Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.336 to 1.0.340 in /exporter/tencentcloudlogserviceexporter Bump github.com/DataDog/agent-payload/v5 from 5.0.10 to 5.0.12 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.42.40 to 1.42.44 in /internal/aws/xray/testdata/sampleapp * Fix issue where empty metrics could be returned (#7502) The scraper was pre-initializing metrics, and would return them regardless of whether or not any data points were actually collected. This resulted in empty metrics being returned. * [exporter/datadog] Always map conventional attributes to tags (#7185) * [datadogexporter] Always map conventional attributes into tags * Add CHANGELOG entry * Use alternative for deprecated linux distro (#7526) * Increase memory limit for zipkin testbed test (#7530) * Update mysqlreceiver to use mdatagen v2 (#7507) * make update-otel (#7520) * make update-otel * Logs() -> LogRecords() * NewDefaultConfigProvider -> MustNewDefaultConfigProvider * fixup: move #7360 changelog to unreleased (#7510) * pkg/resourcetotelemetry: add resource attributes to remaining metric points (#7523) * pkg/resourcetotelemetry: add resource attributes to summary metrics points Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * update CHANGELOG Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * pkg/resourcetotelemetry: add resource attributes to exponential histogram data points Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * [receiver/postgresql] Add integration tests (#7501) This set of tests uses a single containerized instance of postgresql. The tests primarily differ in that they use different values for the databases parameter. * [testbed] Fix MetricsFromFile test (#7538) * Fix MetricsFromFile test This test is failing because it is attempting to unmarshal an old format. This change just updates the format. * Clean up whitespace * [receiver/nginx] Update integration test (#7515) Updates the nginxreceiver's integration test to use the scrapertest package. Also standardizes the layout of the integration test files. Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> * [testbed] Relax constraint on Carbon metric load test (#7541) * Update postgresqlreceiver to use new metadata generator (#7503) * Upgrade to core v0.44.0 (#7542) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * [processor/resourcedetection] Update `os.type` attribute values (#7544) Update the attribute values according to the semantic conventions * [receiver/(all scrapers)] Add doc.go w/ metadata gen tag (#7545) Also remove corresponding codegen.go * Use scrapererror to report partial errors (#7513) The mysqlreceiver was previously logging minor collection errors instead of aggregating them with the scrapererror package. Co-authored-by: Alex Boten <aboten@lightstep.com> * [receiver/apache] Add integration test (#7517) * [receiver/apachet ] Add integration test * tidy * [receiver/ elasticsearch | postgresql | rabbitmq] Minor refactoring of scraper naming convention (#7550) * Minor refactoring of scraper naming convention Some scrapers called their metrics builder 'mb' while others called it 'metricsBuilder'. This just standardizes on 'mb' for brevity. * gofmt * [receiver/nginx] Update to mdatagen v2 (#7549) * [receiver/nginx] Update to mdatagen v2 * chlog++ * [exporter/newrelic] Remove usage of LogRecord Name field (#7563) * [exporter/splunkhec] Deprecate otel_to_hec_fields.name setting (#7560) The LogRecord Name field [is removed](https://github.com/open-telemetry/opentelemetry-specification/pull/2271) from the specification and is [going to be removed](https://github.com/open-telemetry/opentelemetry-proto/pull/357) from the OTLP. * [exporter/datadog] Fix README docs for traces config (#7543) * [exporter/datadog] Fix traces exporter's initialization log (#7564) * [exporter/datadogexporter] Fix traces exporter's initialization log * [exporter/datadogexporter] Update CHANGELOG.md * [exporter/loki] Remove usage of LogRecord Name field (#7565) Fixes #7555 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Remove LogRecord Name field usage from signalfx exporter and receiver (#7553) The LogRecord Name field [is removed](https://github.com/open-telemetry/opentelemetry-specification/pull/2271) from the specification and is [going to be removed](https://github.com/open-telemetry/opentelemetry-proto/pull/357) from the OTLP. * [exporter/dynatrace] Readme - fix TLS' insecure_skip_verify config option (#7567) * [receiver/collectd] Sanitize string recorded in log (#7577) As per CWE-117 recommendations. * Replace path.Join method with filepath.Join method (#6980) * replace path join with filepath join * fix missing imports * fix incorrections * fix incorrect import of path * corrections in files * fix import in jmxreceiver * remove unwanted imports * fix gofmt issue * fix issue in coralogicexporter lints * add os in imports * [exporter/dynatrace] Fix docs for TLS settings (#7568) * [exporter/dynatrace] Fix docs for TLS settings Fixes #7566. * Add changelog * Fix comment * [processor/tailsampling] Add AND policy (#6910) * add combined policy * added combined policy to config test * - rename combined policy to add * rename combined to and * add combined policy * - rename combined policy to add * comments explaining the behavior of the policy * fix merge errors * add changelog rename tests * [exporter/coralogix] Enable component (#7383) * coralogix exporter enable * coralogix exporter enable * fix endpoint exporter_test * [internal/aws] Ensure logged URL is sanitized (#7575) * ensure logged URL is sanitized * [receiver/prometheusexec] Set a default value for `scrape_timeout` (#7587) * `prometheusexec`: default value for `scrape_timeout` * update changelog to include the current change * sanitize logged string (#7576) As per recommendations from CWE-117. * Update go.mod Co-authored-by: Bogdan Drutu <lazy@splunk.com> * Prepare for v0.44.0 release (#7579) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Bump github.com/aws/aws-sdk-go in /internal/aws/xray/testdata/sampleapp (#7737) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.42.44 to 1.42.48. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.42.44...v1.42.48) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * dependabot updates Mon 7 Feb 2022 13:08:34 PST (#7745) Bump github.com/aws/aws-sdk-go from 1.42.44 to 1.42.48 in /exporter/kafkaexporter Bump github.com/aws/aws-sdk-go from 1.42.44 to 1.42.48 in /exporter/awscloudwatchlogsexporter Bump github.com/aws/aws-sdk-go from 1.42.44 to 1.42.48 in /internal/aws/proxy Bump github.com/aws/aws-sdk-go from 1.42.44 to 1.42.48 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go from 1.42.44 to 1.42.48 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.42.44 to 1.42.48 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.42.44 to 1.42.48 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.42.44 to 1.42.48 in /internal/aws/xray Bump github.com/aws/aws-sdk-go from 1.42.44 to 1.42.48 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go from 1.42.44 to 1.42.48 in /processor/resourcedetectionprocessor Bump github.com/aws/aws-sdk-go from 1.42.44 to 1.42.48 in /exporter/awsxrayexporter Bump github.com/aws/aws-sdk-go from 1.42.44 to 1.42.48 in /receiver/awsxrayreceiver Bump go.uber.org/zap from 1.20.0 to 1.21.0 in /receiver/rabbitmqreceiver Bump go.uber.org/zap from 1.20.0 to 1.21.0 in /receiver/apachereceiver Bump go.uber.org/zap from 1.20.0 to 1.21.0 in /receiver/couchbasereceiver Bump go.uber.org/zap from 1.20.0 to 1.21.0 in /receiver/elasticsearchreceiver Bump go.uber.org/zap from 1.20.0 to 1.21.0 in /exporter/coralogixexporter Bump go.uber.org/zap from 1.20.0 to 1.21.0 in /receiver/couchdbreceiver Bump go.uber.org/zap from 1.20.0 to 1.21.0 in /extension/observer/ecstaskobserver Bump go.uber.org/zap from 1.20.0 to 1.21.0 in /internal/aws/ecsutil Bump go.uber.org/zap from 1.20.0 to 1.21.0 in /processor/redactionprocessor Bump go.uber.org/zap from 1.20.0 to 1.21.0 in /receiver/postgresqlreceiver Bump github.com/jaegertracing/jaeger from 1.30.0 to 1.31.0 in /exporter/jaegerthrifthttpexporter Bump go.uber.org/zap from 1.20.0 to 1.21.0 in /receiver/k8seventsreceiver Bump go.uber.org/zap from 1.20.0 to 1.21.0 in /exporter/tencentcloudlogserviceexporter Bump go.uber.org/zap from 1.20.0 to 1.21.0 in /extension/awsproxy Bump google.golang.org/api from 0.66.0 to 0.67.0 in /receiver/googlecloudspannerreceiver Bump go.uber.org/zap from 1.20.0 to 1.21.0 in /receiver/googlecloudspannerreceiver Bump go.uber.org/zap from 1.20.0 to 1.21.0 in /processor/k8sattributesprocessor Bump go.uber.org/zap from 1.20.0 to 1.21.0 in /receiver/mysqlreceiver * [mdatagen] Fix generation of metric.extended_documentation field (#7582) - Fix apache metrics table broken due to a new line at the end of extended_documentation value - Remove a redundant space * [processor/tailsampling] fix AND policy (#7590) * fix and root policy * add PR # to changelog * read testdata for TestCreateProcessor * remove from CHANGELOG * Add changelog for #7590 (#7750) Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * [processor/routing] Do not err on failure to build exporters (#7423) * [processor/routing] Do not err on failure to build exporters When registering the exporters, it is possible that an error is returned when the default exporter isn't found, which is the case when the processor is specified only for one pipeline type for multiple exists. Given that we can't check in which pipelines the processor is active, we can't do much more than just ignore a possible configuration error. Fixes #6920 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * [receiver/prometheus] fix test flakes (#7759) Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * Change "operation:" to "operations:" in some examples that were wrong (#7753) * [receiver/jaeger] Retry allocating port in test (#7751) Fixes #7181 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Update README.md for gcpexporter config (#7749) * Update README.md If `check_interval` is empty, it will throw an error: ``` collector server run finished with error: cannot build pipelines: error creating processor "memory_limiter" in pipeline "metrics": checkInterval must be greater than zero ``` If `limit_mib` is empty, it will throw an error: ``` Error: cannot build pipelines: error creating processor "memory_limiter" in pipeline "traces": memAllocLimit or memoryLimitPercentage must be greater than zero ``` * Update exporter/googlecloudexporter/README.md Co-authored-by: David Ashpole <dashpole@google.com> * [receiver/apache] Update to mdatagen v2 (#7573) * [receiver/apache] Update to mdatagen v2 * Revert instrumentation library name change * Deprecate log_names setting from filter processor (#7552) The LogRecord Name field [is removed](https://github.com/open-telemetry/opentelemetry-specification/pull/2271) from the specification and is [going to be removed](https://github.com/open-telemetry/opentelemetry-proto/pull/357) from the OTLP. * dependabot updates Tue 8 Feb 2022 09:34:30 PST (#7757) * dependabot updates Tue 8 Feb 2022 09:34:30 PST Bump github.com/Shopify/sarama from 1.31.0 to 1.31.1 in /receiver/kafkareceiver Bump github.com/Shopify/sarama from 1.31.0 to 1.31.1 in /exporter/kafkaexporter Bump github.com/shirou/gopsutil/v3 from 3.21.12 to 3.22.1 in /receiver/hostmetricsreceiver Bump github.com/shirou/gopsutil/v3 from 3.21.12 to 3.22.1 in /receiver/awscontainerinsightreceiver Bump github.com/jackc/pgx/v4 from 4.14.1 to 4.15.0 in /extension/storage Bump github.com/shirou/gopsutil/v3 from 3.21.12 to 3.22.1 in /extension/fluentbitextension Bump github.com/Shopify/sarama from 1.31.0 to 1.31.1 in /receiver/kafkametricsreceiver Bump github.com/elastic/go-elasticsearch/v7 from 7.16.0 to 7.17.0 in /exporter/elasticsearchexporter Bump github.com/shirou/gopsutil/v3 from 3.21.12 to 3.22.1 in /testbed Bump cloud.google.com/go/compute from 1.1.0 to 1.2.0 in /processor/resourcedetectionprocessor Bump github.com/signalfx/com_signalfx_metrics_protobuf from 0.0.2 to 0.0.3 in /exporter/signalfxexporter Bump github.com/signalfx/com_signalfx_metrics_protobuf from 0.0.2 to 0.0.3 in /receiver/signalfxreceiver Bump github.com/shirou/gopsutil/v3 from 3.21.12 to 3.22.1 in /exporter/signalfxexporter Bump github.com/shirou/gopsutil/v3 from 3.21.12 to 3.22.1 in /extension/observer/hostobserver * update use of sarama.ConsumerGroup interface * [receiver/prometheusexec] Ensure factory test checks for the default intervals (#7594) * do not set scrape_timeout to fail test with 0 value * use default values for wantPer * add test to check zero value for default values * remove test constants * [receiver/prometheus] Correctly map Description and Unit to pdata (#7748) * [receiver/prometheus] Correctly map Description and Unit to pdata Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * fix changelog Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> Co-authored-by: Alex Boten <aboten@lightstep.com> * [receiver/hostmetrics] Migrate memory scraper to new metrics builder (#7312) * [receiver/hostmetrics] Migrate memory scraper to new metrics builder * Fix CI failures * Fix lint error * Address bootTimeFunc review comment * Address review comments * Move changelog entries from 0.44 to unreleased (#7763) Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * [exporter/datadog] Don't send metadata if hostname is empty (#7426) * [exporter/datadog] Don't send metadata if hostname is empty * Add changelog entry * Add logging about skipping the metadata * [receiver/apache] Update instrumentation library name (#7754) * [receiver/apache] Update instrumentation library name The instrumentation library name used in other scrapers is typically prefixed with 'otelcol'. This change just updates the apachereceiver's name from 'otel/apache' to 'otelcol/apache' * Fix merge oversight * [receiver/k8scluster] Use newer batch and autoscaling APIs (#7406) * Otel-collector-contrib-7386 removing batch/v1beta1 and autoscaling/v2beta1 k8s api from receiver/k8scluster * Otel-collector-contrib-7386 replacing autoscaling/v2beta1 with autoscaling/v2beta2 k8s api from receiver/k8scluster * Otel-collector-contrib-7386 replacing autoscaling/v2beta1 with autoscaling/v2beta2 k8s api from receiver/k8scluster * Otel-collector-contrib-7386 replacing autoscaling/v2beta1 with autoscaling/v2beta2 k8s api from receiver/k8scluster * Otel-collector-contrib-7386 overcome redundant alias for k8s.io/api/autoscaling/v2beta2 * Otel-collector-contrib-7386 Matching k8s Object for Autoscaling Api * Otel-collector-contrib-7386 Matching k8s Object for Batch Api * [exporter/sumologicexporter] Fix handling empty histograms (#7769) Fixes [Sumo Logic exporter panics on on malformed histogram](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/7548) **Link to tracking Issue:** #7548 **Testing:** Unit tests for the case added * Remove usage of LogRecord Name field in tencentcloudlogserviceexporter (#7762) * [receiver/prometheus] Remove OpenCensus conversion pipeline (#7746) * receiver/prometheus: remove OpenCensus translation pipeline Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * Update changelog Co-authored-by: Alex Boten <aboten@lightstep.com> * Add pull-request title guideline (#7752) * Rewrap contributing guidelines Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Bump `github.com/DataDog/datadog-agent/pkg/quantile` to v0.33.0 (#7770) * [exporter/datadog] Remove obsolete configuration warning (#7767) * [exporter/datadog] Add support to skip TLS verification (#7422) * Document TLS option in example config * Apply suggestions from code review Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> * [codeowners] adding pmm-sumo as owner (#7774) As per the comment here https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/3870#issuecomment-1034046853 * Cleanup prw translator public functions (#7776) * Allow to add extra settings; * Remove unnecessary dropped, can also be calculated as `md.MetricCount() - len(tsMap)` * Remove dependency on the collector consumererror in the new API. When deprecated API is remove the dependency on the collector is removed. * Change PRW exporter to the new API; Minor improvement on the errors handling; Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * [testbed] Increase CPU limit on kubernetes_container test (#7773) * clarify when use_start_time_metric would be incorrect and add warning (#7780) * [exporter/loki] Use record attributes as log labels (#7569) * [exporter/loki] Use record attributes as log labels Fixes #6001 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Fix statement that unknown keys are ignored Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> * [translator/jaeger] Cleanup function names (#7775) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * [exporter/signalfx] Refactor conversion code for metrics (#7782) This PR only moves the code to a different file, and fixes few nits. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * [pkg/translator/signalfx] Extract signalfx to metrics conversion in a separate package (#7778) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * [exporter/alibabacloudlogservice] Remove name attribute from logrecord (#7783) * remove name attribute from logrecord Signed-off-by: DiptoChakrabarty <diptochuck123@gmail.com> * unused const removal Signed-off-by: DiptoChakrabarty <diptochuck123@gmail.com> * [exporter/coralogix] Update readme (#7785) * update coralogix readme * Update README.md * fix endpoints table * add coralogixexporter readme changes to changelog * Add @pmm-sumo as an Approver (#7786) The current maintainers unanimously agreed that Przemek qualifies as an approver. Welcome, Przemek! * Remove Name From AWS Cloudwatch Logs Exporter Fixes (#7554) (#7788) **Link to tracking Issue:** (#7554) * Fixes (#6734) CPU Reserved Should Be 1024 Per VCPU ECS Container Insights (#7777) * Remove unused interface, hide unnecessary internal public structs (#7790) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * [exporter/clickhouse] Add component (#6907) * Add ClickHouse Exporter Signed-off-by: Jimmie Han <hanjinming@outlook.com> * reduce the size of first PR about new component * add more words to README.md, config use dsn Signed-off-by: Jimmie Han <hanjinming@outlook.com> * add changelog and versions.yaml Signed-off-by: Jimmie Han <hanjinming@outlook.com> * [exporter/clickhouse]: fist PR to add new component * [exporter/clickhouse]: add queue_size to config field Signed-off-by: Jimmie Han <hanjinming@outlook.com> * [exporter/clickhouse]: add CODEOWNERS Signed-off-by: Jimmie Han <hanjinming@outlook.com> * [exporter/clickhouse]: add internal/components tests Signed-off-by: Jimmie Han <hanjinming@outlook.com> * Refactor signalfx exporter converter to accept whole metrics (#7792) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Bump actions/setup-go from 2.1.5 to 2.2.0 (#7795) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2.1.5 to 2.2.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](https://github.com/actions/setup-go/compare/v2.1.5...v2.2.0) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update Changelog (#7822) - Combine duplicated sections - Move unreleased lines from 0.44.0 - Add nice flags to Deprecations sections where missing * [build] hide lengthy mispell command (#7794) * [build] hide lengthy mispell command Trim command output when running misspell to reduce clutter. Fixes #7784 * make update-otel (#7779) * make update-otel * ensure Config implements Validate * fix test * fix test * make update-otel * update tools * Update dependabot file, change github action to check for this. (#7824) Split lint step into golangci-lint and other checks. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * [pkg/translator/signalfx]: Extract FromMetrics to SignalFx translator package. (#7823) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * [internal/common]: Move testing/util to maps, usage outside of tests already (#7877) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Hacky quick fix to unblock the other PRs (#7880) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * dependabot updates Fri Feb 11 09:18:53 PST 2022 (#7873) * dependabot updates Fri Feb 11 09:18:53 PST 2022 Bump go.opentelemetry.io/otel from 1.3.0 to 1.4.0 in /tracegen Bump go.opentelemetry.io/otel from 1.3.0 to 1.4.0 in /receiver/statsdreceiver Bump go.opentelemetry.io/otel/sdk/export/metric from 0.26.0 to 0.27.0 in /receiver/simpleprometheusreceiver/examples/federation/prom-counter Bump go.mongodb.org/mongo-driver from 1.8.2 to 1.8.3 in /receiver/mongodbreceiver Bump go.opentelemetry.io/otel/sdk from 1.3.0 to 1.4.0 in /tracegen Bump go.opentelemetry.io/otel/sdk from 1.3.0 to 1.4.0 in /receiver/opencensusreceiver Bump go.opentelemetry.io/otel/exporters/prometheus from 0.26.0 to 0.27.0 in /receiver/simpleprometheusreceiver/examples/federation/prom-counter Bump go.opentelemetry.io/otel from 1.3.0 to 1.4.0 in /receiver/simpleprometheusreceiver/examples/federation/prom-counter Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.340 to 1.0.342 in /exporter/tencentcloudlogserviceexporter Bump github.com/aws/aws-sdk-go from 1.42.48 to 1.42.51 in /internal/aws/cwlogs Bump go.opentelemetry.io/otel from 1.3.0 to 1.4.0 in /examples/demo/server Bump go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc from 0.26.0 to 0.27.0 in /examples/demo/server Bump github.com/DataDog/agent-payload/v5 from 5.0.12 to 5.0.15 in /exporter/datadogexporter Bump go.opentelemetry.io/otel/sdk from 1.3.0 to 1.4.0 in /examples/demo/server Bump go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc from 0.26.0 to 0.27.0 in /examples/demo/client Bump go.uber.org/multierr from 1.6.0 to 1.7.0 in /pkg/translator/signalfx Bump go.opentelemetry.io/otel from 1.3.0 to 1.4.0 in /exporter/googlecloudexporter Bump go.opentelemetry.io/otel/trace from 1.3.0 to 1.4.0 in /examples/demo/server Bump go.opentelemetry.io/otel from 1.3.0 to 1.4.0 in /examples/demo/client Bump go.opentelemetry.io/otel/sdk from 1.3.0 to 1.4.0 in /exporter/googlecloudexporter Bump go.opentelemetry.io/otel from 1.3.0 to 1.4.0 in /internal/aws/metrics Bump go.opentelemetry.io/otel/sdk/metric from 0.26.0 to 0.27.0 in /examples/demo/server Bump go.opentelemetry.io/otel/metric from 0.26.0 to 0.27.0 in /examples/demo/client Bump go.opentelemetry.io/otel/trace from 1.3.0 to 1.4.0 in /exporter/googlecloudexporter Bump go.opentelemetry.io/otel/exporters/otlp/otlpmetric from 0.26.0 to 0.27.0 in /examples/demo/client Bump go.opentelemetry.io/otel/exporters/otlp/otlpmetric from 0.26.0 to 0.27.0 in /examples/demo/server Bump go.opentelemetry.io/otel/sdk from 1.3.0 to 1.4.0 in /examples/demo/client * fix import Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com> * [exporter/prometheus] Dropping the condition to replace _ with key_ as __ label is reserved and _ is not (#7506) * adding feature gate changes to disable sanitization on labels that start with '_' * updated the description for sanitizeLabel * updated the flag name to skipSanitizeLabel * Extract internal/common/testing/container to internal/containertest (#7879) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Fix to run trace correctness tests when using make run-correctness-traces-tests (#7899) This means that we never run/test trace correctness, let's see how we've done without that. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * [awsecscontainermetricsreceiver]: remove deadcode (#7898) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * dependabot updates Fri Feb 11 14:04:29 PST 2022 (#7901) Bump go.mongodb.org/atlas from 0.14.0 to 0.15.0 in /receiver/mongodbatlasreceiver Bump google.golang.org/api from 0.67.0 to 0.68.0 in /receiver/googlecloudspannerreceiver Bump google.golang.org/api from 0.67.0 to 0.68.0 in /exporter/f5cloudexporter Bump google.golang.org/api from 0.67.0 to 0.68.0 in /exporter/googlecloudexporter Bump go.uber.org/zap from 1.19.1 to 1.21.0 in /exporter/clickhouseexporter Bump github.com/wavefronthq/wavefront-sdk-go from 0.9.9 to 0.9.10 in /exporter/tanzuobservabilityexporter Bump github.com/aws/aws-sdk-go from 1.42.48 to 1.42.52 in /exporter/awsprometheusremotewriteexporter Bump github.com/aws/aws-sdk-go from 1.42.48 to 1.42.52 in /internal/aws/cwlogs Bump github.com/aws/aws-sdk-go from 1.42.48 to 1.42.52 in /processor/resourcedetectionprocessor Bump github.com/aws/aws-sdk-go from 1.42.48 to 1.42.52 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go from 1.42.48 to 1.42.52 in /internal/aws/proxy Bump github.com/aws/aws-sdk-go from 1.42.48 to 1.42.52 in /receiver/awsxrayreceiver Bump github.com/aws/aws-sdk-go from 1.42.48 to 1.42.52 in /exporter/kafkaexporter Bump github.com/aws/aws-sdk-go from 1.42.48 to 1.42.52 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.42.48 to 1.42.52 in /exporter/awscloudwatchlogsexporter Bump github.com/aws/aws-sdk-go from 1.42.48 to 1.42.52 in /exporter/awsemfexporter Bump github.com/aws/aws-sdk-go from 1.42.48 to 1.42.52 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go from 1.42.48 to 1.42.52 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.42.48 to 1.42.52 in /exporter/awsxrayexporter Bump github.com/aws/aws-sdk-go from 1.42.48 to 1.42.52 in /internal/aws/xray Bump github.com/aws/aws-sdk-go from 1.42.48 to 1.42.52 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.42.48 to 1.42.52 in /internal/aws/awsutil Bump github.com/DataDog/datadog-agent/pkg/quantile from 0.33.0 to 0.33.1 in /exporter/datadogexporter Bump github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/trace from 1.0.0 to 1.3.0 in /exporter/googlecloudexporter Bump github.com/aws/aws-sdk-go from 1.42.48 to 1.42.52 in /internal/aws/xray/testdata/sampleapp * [mdatagen] Generate documentation for metrics enabling/disabling (#7581) The new metrics builder introduced an ability to add optional metrics to scrapers and a settings option to disable/enable particular metrics. This change adds automatically generated documentation for this feature. * [exporter/skywalking] Remove usage of LogRecord Name field (#7827) Fixed #7557 * Move coreinternal testutil and sanitize to common (#7904) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * [build] make it easier to use other versions of go (#7902) Replacing `go` in the Makefile with a variable to make testing new versions of go easier. * Update header levels in Changelog (#7917) Currently release and its sections have the same header level which makes them hard to distinguish. This change updates the header hierarchy. * Use go mod compat, drops support for reproducibility with go 1.16 #7915 * [receiver/hostmetrics] Add memory utilization (#7828) * [exporter/azuremonitorexporter] Logs. (#7403) * adding logs * unit tests * addressing review comments * address review comments * linting * changelog * [exporter/datadog] Move translator and attributes into `model` (#7909) * [exporter/datadog] Move translator and attributes into `model` * [exporter/datadog] Use model version of testutils * [exporter/datadog] Fix `impi` issue * [testbed] Increase limits on OTLP-HTTP tests (#7925) * [testbed] Increase CPU limit on Metric10kDPS/OTLP-HTTP test * Increase Memory limit on Log10kDPS/OTLP-HTTP * [exporter/azuremonitor] Remove deprecated method call (#7932) * [exporter/azuremonitor] Remove deprecated method call * Fix json * [exporter/elasticsearchexporter] Remove usage of deprecated LogRecord.Name field. (#7829) * remove usage of Deprecated LogRecord.Name field. * add CHANGES * fix lint * [prometheusremotewriteexporter] dropping the condition to replace _ with key_ as __ label is reserved and _ is not (#7112) feature gate changes to disable sanitization of labels that start with '_' adding back the changes for feature gate * moving feature gate to a different group to fix lint issue * increasing ExpectedMaxRAM to 110 for Zipkin test TestTrace10kSPS * added testcases for sanitization when sanitizeLabel is turned off Co-authored-by: Alex Boten <aboten@lightstep.com> * [exporter/datadog] Use exact sum and count on distributions when available (#7830) * [exporter/datadog] Modify sketches tests so that they only use MapMetrics * [exporter/datadog] Use exact sum, count and average on sketches * Add Changelog entry * Empty commit to re-trigger CI Co-authored-by: Alex Boten <alex@boten.ca> * [extensions/storage/filestorage]: add compaction on start (#7768) * feat(extension/filestorage): add compaction on start Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> * test(extension/filestorage): add tests and fix found issues Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> * refactor(extensions/storage/filestorage): extract compaction into own config Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> * docs(storage/filestorage): add missing doc for compaction Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> * docs(storage/filestorage): add max_transaction_size being 0 comment Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> * [receiver/hostmetrics] Migrate filesystem scrapper to a new metrics builder (#7772) * regenerate metrics v2 * update config, factory and scraper for metrics v2 * refactor: go fmt * add second emit to keep metrics order * fixed metrics order, updated tests * update changelog, rebase * [exporter/loadbalancing] Allow non-exist hostname on startup (#7935) * allow non-exist dns resolver name on startup * Update exporter/loadbalancingexporter/consistent_hashing.go Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de> * add changelog Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> * [exporter/awskinesis] Add Queue Config Validation (#7914) Co-authored-by: Alex Boten <alex@boten.ca> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> * [processor/transform] Add business logic for handling traces queries. (#7300) * [processor/transform] Add business logic for handling traces queries. * Global parser * func aliases * Start cleanups * Cleanups * Extract methods for trace access * Remove register / unregisterFunction * statement -> query * Split out setter * keep -> keep_keys * lint * TODO(reflect on reflect) * invalid config test * resource.attributes tests * factory tests * Fix test * Prepare v0.45.0 (#7937) * make update-otel Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * s/Type/ValueType Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Update versions.yaml to v0.45.0 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * make update-otel OTEL_VERSION=v0.45.0 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com> * [exporter/sumologic] Move config validation to config (#7936) * sumologicexporter: move config validation to config Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> * sumologicexporter: move config validation to config Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> * changelog: fix Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> * [exporter/elasticsearch] Fix crash with batch processor (#7953) * remove usage of Deprecated LogRecord.Name field. * fix https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/7934 * add CHANGELOG.md * [processor/k8sattributes] Use semconv for k8s.container.restart_count (#7825) * Batch Splunk metric events (#7760) * batch metrics * fix lint * update changelog Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> * [exporter/tanzuobservability] Add internal SDK metric tag (#7826) * Add internal SDK metrics Update TraceExporter and MetricExporter with a tag providing information about otel-collector version. * Update the changelog Add internal SDK metric tag. * Update InternalMetricsTags name Update InternalMetricsTag names to differentiate between metrics and traces exporter usage. * Update go.mod files Update go.mod & go.sum * Fix unit tests Update metrics_exporter_test.go * Fix go.sum Update go.sum after merge. * [receiver/awsfirehose] Add new AWS Kinesis Data Firehose Receiver (#7918) * Initial firehose receiver scaffolding. * Add firehose endpoint delivery request/response based on spec. * Add CloudWatch Metric Stream encoding. * Change unmarshaler to handle multiple records. * Refactor receiver to make more generic. * Add unit tests. * Fix linting naming issues. Add entry for versions.yaml and CHANGELOG.md. Add common attributes to firehose consumer with tests. * Move unmarshaler into internal. Rename encoding to record_type. Change metrics builder to perform less copies. Add additional logging and errors. Add config validation. * Add godocs. Update README with additional detail. * Change metrics data type to summary. * Change string keys to structs. Add additional test for receiver start up. * Initial firehose receiver scaffolding. * Add firehose endpoint delivery request/response based on spec. * Add CloudWatch Metric Stream encoding. * Change unmarshaler to handle multiple records. * Refactor receiver to make more generic. * Add unit tests. * Fix linting naming issues. Add entry for versions.yaml and CHANGELOG.md. Add common attributes to firehose consumer with tests. * Move unmarshaler into internal. Rename encoding to record_type. Change metrics builder to perform less copies. Add additional logging and errors. Add config validation. * Add godocs. Update README with additional detail. * Change metrics data type to summary. * Change string keys to structs. Add additional test for receiver start up. * update changelog Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Bump up dependencies to v0.45.0. Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> * [bugfix] fix dependencies in go.mod files (#7963) * [bugfix] fix dependencies in go.mod files These were incorrectly changed in https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/317d2056d6f26aa39b26bf0f05a2f1e0068add5d. Part of https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/7959 * fix changelog * [receiver/hostmetrics] Migrate process scraper to new metrics builder (#7287) * hostreceiver/processscraper: Migrate the scraper to the mdatagen metrics builder * Rebase and update CHANGELOG * Add AWS Firehose receiver to internal/components. (#7964) Add CODEOWNERS, dependabot, and go.mod entries. Fix CHANGELOG entry. * Prepare v0.45.1 (#8017) Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Remove OnLateArrivingSpans (#8019) Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Do not drop zero trace/span id spans in the jaeger conversion (#7946) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * [exporter/dynatrace] Validate QueueSettings and perform config validation in Validate() instead (#8020) * perform validation in Validate() * update changelog. * fix import grouping. * [exporter/signalfx] Add validation for `sending_queue` setting (#8026) * dependabot updates Sat 19 Feb 2022 15:43:54 PST (#8031) * dependabot updates Sat 19 Feb 2022 15:43:54 PST Bump k8s.io/client-go from 0.23.3 to 0.23.4 in /processor/resourcedetectionprocessor Bump github.com/aws/aws-sdk-go from 1.42.52 to 1.43.1 in /processor/resourcedetectionprocessor Bump k8s.io/client-go from 0.23.3 to 0.23.4 in /receiver/awscontainerinsightreceiver Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.342 to 1.0.350 in /exporter/tencentcloudlogserviceexporter Bump k8s.io/api from 0.23.3 to 0.23.4 in /receiver/awscontainerinsightreceiver Bump k8s.io/apimachinery from 0.23.3 to 0.23.4 in /processor/resourcedetectionprocessor Bump github.com/aws/aws-sdk-go from 1.42.52 to 1.43.1 in /receiver/awscontainerinsightreceiver Bump k8s.io/apimachinery from 0.23.3 to 0.23.4 in /receiver/k8seventsreceiver Bump go.opentelemetry.io/otel/sdk from 1.4.0 to 1.4.1 in /receiver/opencensusreceiver Bump k8s.io/client-go from 0.23.3 to 0.23.4 in /receiver/simpleprometheusreceiver Bump cloud.google.com/go/compute from 1.2.0 to 1.3.0 in /processor/resourcedetectionprocessor Bump k8s.io/api from 0.23.3 to 0.23.4 in /receiver/k8seventsreceiver Bump go.opentelemetry.io/otel from 1.4.0 to 1.4.1 in /receiver/statsdreceiver Bump go.opentelemetry.io/otel/sdk from 1.4.0 to 1.4.1 in /exporter/googlecloudexporter Bump github.com/aws/aws-sdk-go from 1.42.52 to 1.43.1 in /internal/aws/xray/testdata/sampleapp Bump k8s.io/client-go from 0.23.3 to 0.23.4 in /internal/aws/k8s Bump go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp from 0.28.0 to 0.29.0 in /examples/demo/client Bump github.com/aws/aws-sdk-go from 1.42.52 to 1.43.1 in /exporter/datadogexporter Bump go.opentelemetry.io/otel/exporters/otlp/otlptrace from 1.3.0 to 1.4.1 in /tracegen Bump github.com/aws/aws-sdk-go from 1.42.52 to 1.43.1 in /internal/aws/proxy Bump github.com/apache/thrift from 0.15.0 to 0.16.0 in /receiver/kafkareceiver Bump k8s.io/client-go from 0.23.3 to 0.23.4 in /internal/k8sconfig Bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp from 1.3.0 to 1.4.1 in /tracegen * Fix dependency for otlptracegrpc Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Alex Boten <aboten@lightstep.com> * Upgrade to use semantic conventions 1.6.1, no breaking changes (#7926) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * [exporter/signalfxexporter] Updated documentation in the SignalFX exporter for translation rules (#7875) * Remove deprecated functions from jaeger translator (#8032) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * [internal/stanza & receiver/*logreceiver] Update log-collection dependency (#8022) * Capture eventual update path for log-collection library * Update to use pipeline package instead of agent * Update log-collection package names * Capture eventual update path for log-collection library * Pin to main instead of using replace directives * Update to opentelemetry-log-collection@v0.25.0 * dependabot updates Tue 22 Feb 2022 08:54:32 PST (#8061) Bump github.com/aws/aws-sdk-go from 1.43.1 to 1.43.2 in /internal/aws/cwlogs Bump github.com/aws/aws-sdk-go from 1.43.1 to 1.43.2 in /exporter/kafkaexporter Bump github.com/aws/aws-sdk-go from 1.43.1 to 1.43.2 in /exporter/awscloudwatchlogsexporter Bump github.com/aws/aws-sdk-go from 1.43.1 to 1.43.2 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.43.1 to 1.43.2 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.43.1 to 1.43.2 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go from 1.43.1 to 1.43.2 in /exporter/awsxrayexporter Bump github.com/aws/aws-sdk-go from 1.43.1 to 1.43.2 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go from 1.43.1 to 1.43.2 in /exporter/awsprometheusremotewriteexporter Bump github.com/aws/aws-sdk-go from 1.43.1 to 1.43.2 in /processor/resourcedetectionprocessor Bump github.com/aws/aws-sdk-go from 1.43.1 to 1.43.2 in /receiver/awsxrayreceiver Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.350 to 1.0.351 in /exporter/tencentcloudlogserviceexporter Bump github.com/aws/aws-sdk-go from 1.43.1 to 1.43.2 in /internal/aws/proxy Bump github.com/aws/aws-sdk-go from 1.43.1 to 1.43.2 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.43.1 to 1.43.2 in /internal/aws/xray/testdata/sampleapp Bump github.com/aws/aws-sdk-go from 1.43.1 to 1.43.2 in /exporter/awsemfexporter Bump github.com/aws/aws-sdk-go from 1.43.1 to 1.43.2 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.43.1 to 1.43.2 in /internal/aws/xray * [receiver/prometheus]: Fix segfault that can happen when adjusting stale metrics (#8056) Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * [receiver/mysql] Fix data model issues (#7924) Two metrics in the data model contained overlapping data points. This PR separates these into a total of 5 metrics. Change all data points to int, since they are ints * Upgrade to latest core, remove calls to deprecated funcs (#8044) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * [receiver/hostmetrics] Migrate paging scraper to the new metrics builder (#7764) * feat: migrate pagging scrapper to metrics builder api * added generated code * fixed tests * fixed windows metrics * fixed windows metrics * fixed windows metrics * Update CHANGELOG.md * goimports * fixed lint * call Emit just once * call Emit just once * cleanup * goimports * generate code Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> * export Stanza based receiver metrics (#8025) * export Stanza based receiver metrics Added receiver metrics (accepted, refused, etc) to receivers that are based on Stanza * Fix failing tests * fix go mod issues * Incorporate PR comment * fix lint issue * Update Makefile targets to improve process time. (#8099) * Update Makefile targets to improve process time. * Change make gotidy target to use make target * Change make gomoddownload target to use make target Update GA to run in parallel some of the steps. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Fix goporto since porto runs on all go files Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Bump github.com/aws/aws-sdk-go in /extension/observer/ecsobserver (#8094) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.43.2 to 1.43.4. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.43.2...v1.43.4) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix otel-col dependency upgrade for targets that depend only on model (#8100) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * k8sattributes processor documentation PR (#7913) * k8sattributes processor documentation PR I have opened this PR with respect to the following issue which I have raised https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/7912 Below are the addition in the current documentation Daemon set : 1. Adding the env variable for POD IP in downward api for Daemon set ( config example ) 2. OTEL_RESOURCE_ATTRIBUTES config to update the pod ip Config Map 1. Adding resourcedetectionprocessor to the config map config example 2. Adding the k8sattributes config to extract k8s meta data * Update doc.go * Updated a new section with "Optional" config * Update doc.go * removed resourcedetection stanza * removed pod level env * removed pod level env * Update processor/k8sattributesprocessor/doc.go Co-authored-by: Przemek Maciolek <58699843+pmm-sumo@users.noreply.github.com> * Update processor/k8sattributesprocessor/doc.go Agreed , it should be part of the doc Co-authored-by: Przemek Maciolek <58699843+pmm-sumo@users.noreply.github.com> * removed empty line * Update doc.go * Updating the K8s otel-collector.yaml file K8sprocessor uses resource level attribute to fetch k8s metadata using k8sattributeprocessor. Hence adding the code part in the example config for users to look at, also refers to the issue https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/7912 * Update examples/kubernetes/otel-collector.yaml Co-authored-by: Przemek Maciolek <58699843+pmm-sumo@users.noreply.github.com> * Update examples/kubernetes/otel-collector.yaml Co-authored-by: Przemek Maciolek <58699843+pmm-sumo@users.noreply.github.com> * Update otel-collector.yaml * Update otel-collector.yaml * fixed the changes to be more generic * connection does not uses asso.Name * Update doc.go * Update otel-collector.yaml Co-authored-by: Przemek Maciolek <58699843+pmm-sumo@users.noreply.github.com> Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> * dependabot updates Tue 22 Feb 2022 14:45:35 PST (#8103) Bump github.com/signalfx/sapm-proto from 0.7.2 to 0.9.0 in /exporter/sapmexporter Bump github.com/aws/aws-sdk-go from 1.43.2 to 1.43.4 in /exporter/awscloudwatchlogsexporter Bump github.com/aws/aws-sdk-go from 1.43.2 to 1.43.4 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go from 1.43.2 to 1.43.4 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go from 1.43.2 to 1.43.4 in /exporter/kafkaexporter Bump github.com/aws/aws-sdk-go from 1.43.2 to 1.43.4 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.43.2 to 1.43.4 in /exporter/awsprometheusremotewriteexporter Bump github.com/aws/aws-sdk-go from 1.43.2 to 1.43.4 in /exporter/awsemfexporter Bump github.com/aws/aws-sdk-go from 1.43.2 to 1.43.4 in /internal/aws/cwlogs Bump github.com/aws/aws-sdk-go from 1.43.2 to 1.43.4 in /exporter/awsxrayexporter Bump github.com/aws/aws-sdk-go from 1.43.2 to 1.43.4 in /processor/resourcedetectionprocessor Bump github.com/aws/aws-sdk-go from 1.43.2 to 1.43.4 in /receiver/awsxrayreceiver Bump github.com/aws/aws-sdk-go from 1.43.2 to 1.43.4 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.43.2 to 1.43.4 in /internal/aws/proxy Bump github.com/aws/aws-sdk-go from 1.43.2 to 1.43.4 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.43.2 to 1.43.4 in /internal/aws/xray/testdata/sampleapp Bump github.com/aws/aws-sdk-go from 1.43.2 to 1.43.4 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.43.2 to 1.43.4 in /internal/aws/xray Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.351 to 1.0.352 in /exporter/tencentcloudlogserviceexporter Bump github.com/klauspost/compress from 1.14.2 to 1.14.4 in /exporter/honeycombexporter * [exporter/sapm] Add sending_queue validation (#8023) * Upgrade to github.com/signalfx/sapm-proto v0.9.0 (#8105) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Upgrade deps, fix calls to deprecated funcs (#8104) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Add confighttp.HTTPClientSettings To Resource Detection Config Fixes … (#7518) * Add confighttp.HTTPClientSettings To Resource Detection Config Fixes (#7397) * Create and use helper methods for storing http.Client in the context Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * Fix lint issue Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> Co-authored-by: Anthony J Mirabella <a9@aneurysm9.com> * [exporter/tanzuobservability] Set a field `source` on the span as per OTLP resources (#7929) * Update OTel Collector's Exporter to match WF Proxy Handling of `source` Add Source to span object. * Update CHANGELOG.md Update OTel Collector's Exporter to match WF Proxy Handling of source. * Add default value for source Update transformer.go to set-up default value for the source. * Add a README.md and remove duplicate resource attributes from Span. Update README.md with information about the new attribute `source`. * Unit tests. Add unit tests to verify new source tag value. * Unit tests. Add unit tests to verify new source tag value. * Use semconv constants. Update transformer.go & an unit test transformer_test.go with semconv constants. * Do not update pdata.Traces. Create a copy of pdata.Traces before removing duplicate attributes. * Introduce a constant for source. Introduce a constant of labelSource = "source" to exporter.go, and use that instead of "source" everywhere. * Fix unit test. Add t.Fail() to make sure test fails in case of an unexpected behaviour. * Avoid copying AttributeMap. Avoid copying AttributeMap to reduce memory usage. * Avoid copying AttributeMap. Avoid copying AttributeMap to reduce memory usage. * Fix Lint failure Remove unnecessary use of if. * Fix Lint failure Fix import issues. * [exporter/honeycomb] Update Honeycomb exporter to call QueueSettings Validate (#8113) * update honeycomb exporter to call QueueSettings.validate * Update exporter/honeycombexporter/config.go Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> * [receiver/mongodbatlasreceiver]: add / rename a few attributes (#7960) * [receiver/mongodbatlasreceiver]: add a few useful attributes to receiver * [receivers/mongodbatlasreceiver] add and rename a few attributes * Update CHANGELOG.md Co-authored-by: Alex Boten <alex@boten.ca> * [internal/stanza] Convert non-string attributes (#8081) * [internal/stanza] Convert non-string attributes * Pin otel-log-collection to main * Support writing more types as binary Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com> * Fix update-dep script, which was not updating the model (#8123) This bug was added recently https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/8100, so nothing to worry. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * [exporter/tanzuobservability] Add resource attributes to WF metrics (#8101) 1. Add attributes from the Resource to the resulting WF metric tags. 2. When transforming an OTLP metric to a Wavefront metric, set the source value. Link to tracking Issue: N/A Testing: Unit Testing & Manual Testing * Upgrade core dependendency (#8122) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Bump opentelemetry-log-collection library to v0.26.0 (#8124) * [exporter/influxdb] Add logic to validate the config (#8016) * add logic for validate method in influxdb exporter Signed-off-by: DiptoChakrabarty <diptochuck123@gmail.com> * fix lint issues * change error message * Adding @MovieStoreGuy as code owner for several components (#8126) * Remove tigrannajaryan as Maintainer (#8128) I am no longer able to allocate time to be a maintainer of the Collector contrib due to focusing on other parts of OpenTelemetry. I will continue fulfilling a maintainer responsibility of the Collector core. Thank you all, it was a pleasure working with you! And who knows, I may be able to return sometime in the future. I am moving myself to the Emeritus section according to the rules introduced in https://github.com/open-telemetry/community/pull/961 P.S. We should add other previous approvers/maintainers in the Emeritus section. * Remove tigrannajaryan from autoassign list (#8162) * dependabot updates Mon 28 Feb 2022 14:02:38 PST (#8165) Bump github.com/aws/aws-sdk-go from 1.43.4 to 1.43.7 in /internal/aws/cwlogs Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.352 to 1.0.356 in /exporter/tencentcloudlogserviceexporter Bump google.golang.org/api from 0.68.0 to 0.70.0 in /receiver/googlecloudspannerreceiver Bump github.com/Shopify/sarama from 1.31.1 to 1.32.0 in /exporter/kafkaexporter Bump github.com/Shopify/sarama from 1.31.1 to 1.32.0 in /receiver/kafkareceiver Bump github.com/aws/aws-sdk-go from 1.43.4 to 1.43.7 in /exporter/awscloudwatchlogsexporter Bump github.com/aws/aws-sdk-go from 1.43.4 to 1.43.7 in /exporter/kafkaexporter Bump github.com/aws/aws-sdk-go from 1.43.4 to 1.43.7 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.43.4 to 1.43.7 in /internal/aws/proxy Bump github.com/aws/aws-sdk-go from 1.43.4 to 1.43.7 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.43.4 to 1.43.7 in /receiver/awscontainerinsightreceiver Bump github.com/influxdata/influxdb-observability/common from 0.2.13 to 0.2.14 in /exporter/influxdbexporter Bump github.com/influxdata/influxdb-observability/otel2influx from 0.2.13 to 0.2.14 in /exporter/influxdbexporter Bump github.com/influxdata/influxdb-observability/influx2otel from 0.2.13 to 0.2.14 in /receiver/influxdbreceiver Bump github.com/influxdata/influxdb-observability/common from 0.2.13 to 0.2.14 in /receiver/influxdbreceiver Bump actions/setup-go from 2.2.0 to 3 Bump github.com/aws/aws-sdk-go from 1.43.4 to 1.43.7 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.43.4 to 1.43.7 in /internal/aws/xray/testdata/sampleapp Bump github.com/aws/aws-sdk-go from 1.43.4 to 1.43.7 in /internal/aws/xray Bump github.com/Shopify/sarama from 1.31.1 to 1.32.0 in /receiver/kafkametricsreceiver Bump google.golang.org/api from 0.68.0 to 0.70.0 in /exporter/googlecloudexporter Bump github.com/elastic/go-elasticsearch/v7 from 7.17.0 to 7.17.1 in /exporter/elasticsearchexporter Bump github.com/jstemmer/go-junit-report from 0.9.1 to 1.0.0 in /internal/tools Bump github.com/aws/aws-sdk-go from 1.43.4 to 1.43.7 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go from 1.43.4 to 1.43.7 in /exporter/awsprometheusremotewriteexporter Bump google.golang.org/api from 0.68.0 to 0.70.0 in /exporter/f5cloudexporter Bump github.com/aws/aws-sdk-go from 1.43.4 to 1.43.7 in /exporter/datadogexporter Bump github.com/DataDog/agent-payload/v5 from 5.0.15 to 5.0.16 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.43.4 to 1.43.7 in /exporter/awsemfexporter * [processor/resourcedetectionprocessor] Add examples and structure to README.md (#8164) * Bump actions/setup-go from 2.2.0 to 3 (#8146) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2.2.0 to 3. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](https://github.com/actions/setup-go/compare/v2.2.0...v3) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [processor/routing] Expand error handling on failure to build exporters (#8125) * expand error handling on failure to build exporters * update changelog * add testcase scenario * run gofmt and add shutdown * fix imports * [pkg/translator/prometheusremotewrite] Support non-string resource attributes (#8116) * dependabot updates Mon 28 Feb 2022 16:31:49 PST (#8183) Bump github.com/aws/aws-sdk-go from 1.43.7 to 1.43.8 in /exporter/kafkaexporter Bump github.com/aws/aws-sdk-go from 1.43.7 to 1.43.8 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go from 1.43.7 to 1.43.8 in /exporter/awsprometheusremotewriteexporter Bump github.co…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Up until now, Datadog distributions generated from OTLP Histograms used approximate values for the sum, count and average fields, estimated from the bucket information. Since the sum and count are always available on OTLP Histograms, we can replace our estimates with the exact values on the Datadog distributions produced here.
In particular:
This PR also includes some refactoring of unit tests to make this change easier, and a minor difference on how to deal with the 'invalid sum but valid count' edge case.
Link to tracking Issue: Relates to #7065, also has test from #6129
Testing: Added unit tests to ensure exact sum and count are used for delta and cumulative Histograms