[mdatagen] Define type for number data points in metadata.yaml #6684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
changed the title
dmitryax
force-pushed
the
add-number-type
branch
3 times, most recently
from
98bc096
to
065c64b
Compare
djaglowski
reviewed
Dec 10, 2021
djaglowski
approved these changes
Dec 10, 2021
bogdandrutu
reviewed
Dec 10, 2021
bogdandrutu
reviewed
Dec 10, 2021
dmitryax
force-pushed
the
add-number-type
branch
4 times, most recently
from
5dc8b0b
to
53ff503
Compare
Define number type of data points for all scrapers. Old metadata generator doesn't use it in generated code, only in documentation. New generator uses this field both in generated code and documentation.
dmitryax
force-pushed
the
add-number-type
branch
from
53ff503
to
487c5a0
Compare
|
@bogdandrutu PTAL |
povilasv
referenced
this pull request
in coralogix/opentelemetry-collector-contrib
Dec 19, 2022
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define type of number data points for all scrapers.
Old metadata generator doesn't use it in generated code, only in documentation. New generator uses this field both in generated code and documentation.
Issue: open-telemetry/opentelemetry-collector#10904
Includes fix from: #6683