Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jpkrohling as owner for some components #6531

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

jpkrohling
Copy link
Member

@jpkrohling jpkrohling commented Dec 6, 2021

  • 1st commit adds jpkrohling to a few components
  • 2nd commit sorts entries alphabetically

Related to #3870

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

@jpkrohling jpkrohling requested review from a team and anuraaga December 6, 2021 11:41
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
exporter/tanzuobservabilityexporter/ @open-telemetry/collector-contrib-approvers @oppegard @thepeterstone @keep94
exporter/tencentcloudlogserviceexporter/ @open-telemetry/collector-contrib-approvers @wgliang @yiyang5055
exporter/influxdbexporter/ @open-telemetry/collector-contrib-approvers @jacobmarble @8none1
exporter/uptraceexporter/ @open-telemetry/collector-contrib-approvers @vmihailenco
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was removed in #4458 so we can delete this line

.github/CODEOWNERS Show resolved Hide resolved
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but left some comments that can either be dealt here or in a separate PR

@jpkrohling
Copy link
Member Author

Given the potential for conflicts, I'll merge this as is and send in a new PR with the requested changes.

@jpkrohling jpkrohling merged commit de9c9bb into open-telemetry:main Dec 6, 2021
povilasv referenced this pull request in coralogix/opentelemetry-collector-contrib Dec 19, 2022
…6531)

This change updates values returned by `StabilityLevel.String` to be consistent with other enum types:
  - All returned strings are capitalized.
  - "Undefined" is returned only for `StabilityLevelUndefined`.
  - "" is returned for integers that are out of StabilityLevel enum range.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants