[exporter/tanzuobservability] Add histogram consumer #6389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keep94
force-pushed
the
histogram_metrics
branch
from
3b2bb9b
to
b058873
Compare
keep94
changed the title
keep94
force-pushed
the
histogram_metrics
branch
from
2f59e26
to
e38afa6
Compare
oppegard
suggested changes
Nov 24, 2021
oppegard
approved these changes
Nov 25, 2021
thepeterstone
approved these changes
Nov 30, 2021
Use for..range where possible. Sum up bucket counts for wavefront. Make tests easier to read.
keep94
force-pushed
the
histogram_metrics
branch
from
5e244f0
to
58fbd32
Compare
keep94
force-pushed
the
histogram_metrics
branch
from
58fbd32
to
54c4dc7
Compare
bogdandrutu
reviewed
Dec 10, 2021
jpkrohling
reviewed
Dec 14, 2021
jpkrohling
changed the title
jpkrohling
changed the title
|
If you want to work on the pending items on a follow-up PR, let me know and I'll merge this as is. |
|
I believe I have addressed all pending comments. Would you please have another look? I decided to control whether internal metrics get sent from the top level metricConsumer type rather than from each typedMetricConsumer. Now, typedMetricConsumer.PushInternalMetrics() always sends internal metrics if called. A bool flag controls whether the top level metricConsumer calls PushInternalMetrics() on each typedMetricConsumer. |
jpkrohling
approved these changes
Dec 17, 2021
jpkrohling
changed the title
povilasv
referenced
this pull request
in coralogix/opentelemetry-collector-contrib
Dec 19, 2022
fixes #6389 Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add support for cumulative histograms
Testing:
Unit tests.