Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/observer/docker] add ListAndWatch to observer #5851

Merged
merged 3 commits into from
Oct 28, 2021

Conversation

mstumpfx
Copy link

@mstumpfx mstumpfx commented Oct 21, 2021

Description: Adds the ListAndWatch capability to the Docker observer, and integration tests to help support it. There will be another PR after this one to add watching the docker container events stream to ListAndWatch to help modify endpoints in more real time, out of of the initial load and cache refresh interval.

Link to tracking Issue: #4446

Testing: Added new integration tests to test for some observer functionality. More will be added in the next PR when the container event stream is being watched and used to add/update/remove endpoints.

@mstumpfx mstumpfx force-pushed the docker-observer-p2 branch 2 times, most recently from 5cc421d to 2d3d9fc Compare October 21, 2021 03:29
@mstumpfx mstumpfx marked this pull request as ready for review October 21, 2021 03:36
@mstumpfx mstumpfx requested review from a team and codeboten October 21, 2021 03:36
@mstumpfx mstumpfx force-pushed the docker-observer-p2 branch 3 times, most recently from 556302f to 4b6eb34 Compare October 21, 2021 17:36
@rmfitzpatrick
Copy link
Contributor

rmfitzpatrick commented Oct 21, 2021

Not introduced here, but I remembered that the receiver creator uses endpoint target scheme of host/ip:port so the existing target functionality would require setting ports manually in target receiver configs**: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/extension/observer/k8sobserver/handler.go#L88

@mstumpfx
Copy link
Author

mstumpfx commented Oct 21, 2021

Not introduced here, but I remembered that the receiver creator uses endpoint target scheme of host/ip:port so the existing target functionality would require setting ports manually in target receiver configs**: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/extension/observer/k8sobserver/handler.go#L88

@rmfitzpatrick good catch, thanks, I just updated the target in this PR.

@dmitryax
Copy link
Member

Please rebase

@dmitryax dmitryax added the ready to merge Code review completed; ready to merge by maintainers label Oct 27, 2021
@bogdandrutu bogdandrutu merged commit f4ba502 into open-telemetry:main Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants