Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a trace exporter to Azure Monitor #39

Merged
merged 13 commits into from
Dec 3, 2019
Merged

Adding a trace exporter to Azure Monitor #39

merged 13 commits into from
Dec 3, 2019

Commits on Dec 2, 2019

  1. Adding a trace exporter to Azure Monitor 

    This exporter transforms the current wire format Spans into constructs
defined in
[ApplicationInsights-Go](github.com/Microsoft/ApplicationInsights-Go/appinsights/contracts).

Once a Span is transformed it is sent to Azure Monitor via a transportChannel
interface. There is an implementation of that interface method inside
ApplicationInsights-Go package that ultimately ultimately sent to Azure
Monitor via a REST API. This package takes care of appropriate retries,
batching, and buffering (in-memory only).

Once the OpenTelemetry wire format is incorporated into the collector I
will make the switch to that format. The changes should not be too bad.

This PR does not:
- export Span events
- export Span links,
- implement a metrics exporter

Test code coverage is > 90%
    @pcwiese
    pcwiese committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    01ceb8c View commit details
    Browse the repository at this point in the history

  2. Wiring up the Azure Monitor exporter via local module redirect

    @pcwiese
    pcwiese committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    41a027f View commit details
    Browse the repository at this point in the history

  3. Adding slightly more test coverage

    @pcwiese
    pcwiese committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    1c55899 View commit details
    Browse the repository at this point in the history

  4. Addressing some PR comments

    @pcwiese
    pcwiese committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    59b4208 View commit details
    Browse the repository at this point in the history

  5. Rename toHex -> idToHex

    @pcwiese
    pcwiese committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    e3c7ef1 View commit details
    Browse the repository at this point in the history

  6. Address more PR comments

    @pcwiese
    pcwiese committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    d19f65b View commit details
    Browse the repository at this point in the history

  7. Plumb zap.Logger through to the exporter

    @pcwiese
    pcwiese committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    d1ad3d8 View commit details
    Browse the repository at this point in the history

  8. Satisfy impi import validation

    @pcwiese
    pcwiese committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    1d66d39 View commit details
    Browse the repository at this point in the history

  9. Sanitize envelope fix

    @pcwiese
    pcwiese committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    8544bd9 View commit details
    Browse the repository at this point in the history

  10. Numeric attribute values -> measurements collection

    @pcwiese
    pcwiese committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    3bdc21a View commit details
    Browse the repository at this point in the history

  11. Remove the exporter Debug configuration flag and just use the informa… 

    …tion available in the zap.Logger
    @pcwiese
    pcwiese committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    3493c62 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2019

  1. Adding a config validation check

    @pcwiese
    pcwiese committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    739f9a2 View commit details
    Browse the repository at this point in the history

  2. Addressing PR comments

    @pcwiese
    pcwiese committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    9ca7e19 View commit details
    Browse the repository at this point in the history