Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cadvisor to aws container insight receiver #3802

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Add cadvisor to aws container insight receiver #3802

merged 1 commit into from
Jun 21, 2021

Conversation

pxaws
Copy link
Contributor

@pxaws pxaws commented Jun 17, 2021

Description:
To reduce the size of the original PR: #3414, I create the current PR for setting up cadvisor:

  • embed cadvisor lib inside and use it collect container stats
  • use extractors to generate metrics based on container stats

Link to tracking Issue:
#2307

Testing:
Unit tests.

@pxaws pxaws requested review from a team and bogdandrutu June 17, 2021 16:39
@pxaws pxaws changed the title add cadvisor to aws container insight receiver Add cadvisor to aws container insight receiver Jun 17, 2021
Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! - Approved as the same code has been reviewed in another PR.

@alolita
Copy link
Member

alolita commented Jun 17, 2021

Hi @anuraaga @Aneurysm9 can you please review? Thx.

@alolita alolita added the ready to merge Code review completed; ready to merge by maintainers label Jun 18, 2021
@bogdandrutu bogdandrutu merged commit 608c5c2 into open-telemetry:main Jun 21, 2021
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
* Bump github.com/jaegertracing/jaeger from 1.24.0 to 1.25.0

Bumps [github.com/jaegertracing/jaeger](https://github.com/jaegertracing/jaeger) from 1.24.0 to 1.25.0.
- [Release notes](https://github.com/jaegertracing/jaeger/releases)
- [Changelog](https://github.com/jaegertracing/jaeger/blob/master/CHANGELOG.md)
- [Commits](jaegertracing/jaeger@v1.24.0...v1.25.0)

---
updated-dependencies:
- dependency-name: github.com/jaegertracing/jaeger
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Add logger parameter to Jaeger Agent HTTP server

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants