Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Spelling receiver/u...z #37611

Merged
merged 12 commits into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions receiver/udplogreceiver/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Many parsers operators can be configured to embed certain followup operations su

If set, the `multiline` configuration block instructs the `udplog` receiver to split log entries on a pattern other than newlines.

**note** If `multiline` is not set at all, it wont't split log entries at all. Every UDP packet is going to be treated as log.
**note** If `multiline` is not set at all, it won't split log entries at all. Every UDP packet is going to be treated as log.
**note** `multiline` detection works per UDP packet due to protocol limitations.

The `multiline` configuration block must contain exactly one of `line_start_pattern` or `line_end_pattern`. These are regex patterns that
Expand All @@ -70,7 +70,7 @@ for other encodings available.

#### `async` configuration

If set, the `async` configuration block instructs the `udp_input` operator to read and process logs asynchronsouly and concurrently.
If set, the `async` configuration block instructs the `udp_input` operator to read and process logs asynchronously and concurrently.

**note** If `async` is not set at all, a single thread will read lines synchronously.

Expand Down
2 changes: 1 addition & 1 deletion receiver/vcenterreceiver/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func (vc *vcenterClient) EnsureConnection(ctx context.Context) error {
return nil
}

// Disconnect will logout of the autenticated session
// Disconnect will logout of the authenticated session
func (vc *vcenterClient) Disconnect(ctx context.Context) error {
if vc.sessionManager != nil {
return vc.sessionManager.Logout(ctx)
Expand Down
4 changes: 2 additions & 2 deletions receiver/vcenterreceiver/internal/mockserver/client_mock.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ func routeBody(t *testing.T, requestType string, body map[string]any) ([]byte, e
case "Logout":
return loadResponse("logout.xml")
case "RetrievePropertiesEx":
return routeRetreivePropertiesEx(t, body)
return routeRetrievePropertiesEx(t, body)
case "QueryPerf":
return routePerformanceQuery(t, body)
case "CreateContainerView":
Expand All @@ -91,7 +91,7 @@ func routeBody(t *testing.T, requestType string, body map[string]any) ([]byte, e
return []byte{}, errNotFound
}

func routeRetreivePropertiesEx(t *testing.T, body map[string]any) ([]byte, error) {
func routeRetrievePropertiesEx(t *testing.T, body map[string]any) ([]byte, error) {
rp, ok := body["RetrievePropertiesEx"].(map[string]any)
require.True(t, ok)
specSet := rp["specSet"].(map[string]any)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3356,7 +3356,7 @@
<key>153</key>
<nameInfo>
<label>Net Throughput Contention</label>
<summary>The aggregate network droppped packets for the host</summary>
<summary>The aggregate network dropped packets for the host</summary>
<key>throughput.contention</key>
</nameInfo>
<groupInfo>
Expand Down Expand Up @@ -8064,7 +8064,7 @@
<key>421</key>
<nameInfo>
<label>VMKMEM minfree</label>
<summary>Mininum amount of machine memory that VMkernel likes to keep free</summary>
<summary>Minimum amount of machine memory that VMkernel likes to keep free</summary>
<key>kernel.minfree</key>
</nameInfo>
<groupInfo>
Expand Down
4 changes: 2 additions & 2 deletions receiver/wavefrontreceiver/wavefront_parser.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ var (
_ protocol.ParserConfig = (*WavefrontParser)(nil)
)

// Only two chars can be espcaped per Wavafront SDK, see
// Only two chars can be escaped per Wavefront SDK, see
// https://github.com/wavefrontHQ/wavefront-sdk-go/blob/2c5891318fcd83c35c93bba2b411640495473333/senders/formatter.go#L20
var escapedCharReplacer = strings.NewReplacer(
`\"`, `"`, // Replaces escaped double-quotes
`\n`, "\n", // Repaces escaped new-line.
`\n`, "\n", // Replaces escaped new-line.
)

// BuildParser creates a new Parser instance that receives Wavefront metric data.
Expand Down
8 changes: 4 additions & 4 deletions receiver/webhookeventreceiver/req_to_log_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,12 @@ func TestReqToLog(t *testing.T) {
if v, ok := attributes.Get("qparam1"); ok {
require.Equal(t, "hello", v.AsString())
} else {
require.Fail(t, "faild to set attribute from query parameter 1")
require.Fail(t, "failed to set attribute from query parameter 1")
}
if v, ok := attributes.Get("qparam2"); ok {
require.Equal(t, "world", v.AsString())
} else {
require.Fail(t, "faild to set attribute query parameter 2")
require.Fail(t, "failed to set attribute query parameter 2")
}
},
},
Expand Down Expand Up @@ -85,12 +85,12 @@ func TestReqToLog(t *testing.T) {
if v, ok := attributes.Get("qparam1"); ok {
require.Equal(t, "hello", v.AsString())
} else {
require.Fail(t, "faild to set attribute from query parameter 1")
require.Fail(t, "failed to set attribute from query parameter 1")
}
if v, ok := attributes.Get("qparam2"); ok {
require.Equal(t, "world", v.AsString())
} else {
require.Fail(t, "faild to set attribute query parameter 2")
require.Fail(t, "failed to set attribute query parameter 2")
}
},
},
Expand Down
2 changes: 1 addition & 1 deletion receiver/windowsperfcountersreceiver/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ service:

## Known Limitation

- The network interface is not available inside the container. Hence, the metrics for the object `Network Interface` aren't generated in that scenario. In the case of sub-process, it captures `Network Interface` metrics. There is a similar open issue in [Github](https://github.com/influxdata/telegraf/issues/5357) and [Docker](https://forums.docker.com/t/unable-to-collect-network-metrics-inside-windows-container-on-windows-server-2016-data-center/69480) forum.
- The network interface is not available inside the container. Hence, the metrics for the object `Network Interface` aren't generated in that scenario. In the case of sub-process, it captures `Network Interface` metrics. There is a similar open issue in [GitHub](https://github.com/influxdata/telegraf/issues/5357) and [Docker](https://forums.docker.com/t/unable-to-collect-network-metrics-inside-windows-container-on-windows-server-2016-data-center/69480) forum.

- The counter category `Process` is [unreliable with multiple instances of the same process][1]. On Windows 11 and later, it is recommended to use `Process V2` instead as it includes the process ID in the instance name. For versions prior to Windows 11 it is possible to [configure the `Process` counter category to include the PID in the instance name][2].

Expand Down
2 changes: 1 addition & 1 deletion receiver/zipkinreceiver/trace_receiver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ func compressZlib(body []byte) (*bytes.Buffer, error) {
return &buf, nil
}

func TestConvertSpansToTraceSpans_JSONWithoutSerivceName(t *testing.T) {
func TestConvertSpansToTraceSpans_JSONWithoutServiceName(t *testing.T) {
blob, err := os.ReadFile("./testdata/sample2.json")
require.NoError(t, err, "Failed to read sample JSON file: %v", err)
zi := newTestZipkinReceiver()
Expand Down