Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporters/elasticsearch] remove stale deprecated index option #37094

Merged

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Jan 8, 2025

Description

This option has been deprecated for 3 years. Removing it as a cleanup.

@dmathieu dmathieu marked this pull request as ready for review January 8, 2025 15:12
@dmathieu dmathieu requested a review from a team as a code owner January 8, 2025 15:12
@dmathieu dmathieu requested a review from MovieStoreGuy January 8, 2025 15:12
.chloggen/elasticsearch-remove-index.yaml Outdated Show resolved Hide resolved
Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
Copy link
Contributor

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another reference that should probably be removed.

.chloggen/elasticsearch-remove-index.yaml Show resolved Hide resolved
@MovieStoreGuy MovieStoreGuy merged commit c695ab0 into open-telemetry:main Jan 13, 2025
161 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 13, 2025
AkhigbeEromo pushed a commit to sematext/opentelemetry-collector-contrib that referenced this pull request Jan 13, 2025
…telemetry#37094)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This option has been deprecated for 3 years. Removing it as a cleanup.

---------

Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
@dmathieu dmathieu deleted the elasticsearch-remove-index branch January 13, 2025 07:56
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this pull request Jan 26, 2025
…telemetry#37094)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This option has been deprecated for 3 years. Removing it as a cleanup.

---------

Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants