Add cluster-level metrics to container insight receiver #3683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxiamxia
reviewed
Jun 2, 2021
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Outdated
Show resolved
Hide resolved
mxiamxia
reviewed
Jun 2, 2021
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Outdated
Show resolved
Hide resolved
mxiamxia
reviewed
Jun 2, 2021
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Outdated
Show resolved
Hide resolved
mxiamxia
reviewed
Jun 2, 2021
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Outdated
Show resolved
Hide resolved
anuraaga
reviewed
Jun 2, 2021
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Outdated
Show resolved
Hide resolved
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Show resolved
Hide resolved
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Show resolved
Hide resolved
mxiamxia
approved these changes
Jun 3, 2021
Aneurysm9
suggested changes
Jun 4, 2021
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Show resolved
Hide resolved
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Show resolved
Hide resolved
pxaws
changed the title
Aneurysm9
reviewed
Jun 7, 2021
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Show resolved
Hide resolved
Aneurysm9
approved these changes
Jun 8, 2021
alolita
added
the
ready to merge
|
Does this fully resolve #2307 ? If so update the PR description to reflect that. |
No. It doesn't resolve the issue. There are still some pending PRs for the issue. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add
k8sapiservercomponent to collect cluster-level metrics from k8s api server:kubernetes/client-go. A dedicated configmap is used as the lock resource. Multiple receivers will try to acquire the lock and only one will succeed and generate cluster-level metrics.Link to tracking Issue:
#2307
Testing:
Unit tests