[pkg/ottl] Add support for non-element nodes in GetXML #36821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
get-xml-nonelements
branch
from
ee5f16d to
ded3822
Compare
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
djaglowski
force-pushed
the
get-xml-nonelements
branch
from
ded3822 to
c9f4be1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36821 +/- ##
=======================================
Coverage 79.78% 79.78%
=======================================
Files 2215 2215
Lines 208604 208612 +8
=======================================
+ Hits 166425 166439 +14
+ Misses 36612 36611 -1
+ Partials 5567 5562 -5 ☔ View full report in Codecov by Sentry. |
evan-bradley
approved these changes
Dec 13, 2024
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…y#36821) When originally implemented, only element nodes were selectable, but there doesn't seem to be any reason why we shouldn't be able to select these other types as well.
mterhar
pushed a commit
to mterhar/opentelemetry-collector-contrib
that referenced
this pull request
Dec 19, 2024
…y#36821) When originally implemented, only element nodes were selectable, but there doesn't seem to be any reason why we shouldn't be able to select these other types as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When originally implemented, only element nodes were selectable, but there doesn't seem to be any reason why we shouldn't be able to select these other types as well.