[exporter/azuremonitor] fix not exporting to azure monitor when using instrumentaion key #36794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pcwiese , could you help to take a look? thanks! |
MovieStoreGuy
approved these changes
Dec 15, 2024
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
… instrumentaion key (open-telemetry#36794) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Fixed not exporting to azure monitor when using instrumentation key without endpoint. If default config is set, it'll never goto the branch https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/ab0f6a24521104e2e06c11673bc462aa4a5703e4/exporter/azuremonitorexporter/connection_string_parser.go#L47 <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36704 <!--Describe what testing was performed and which tests were added.--> #### Testing tested locally and can send metrics/logs/traces to `appinsights` successfully. And passes all tests. <!--Describe the documentation added.--> #### Documentation no need to update. <!--Please delete paragraphs that you did not use before submitting.-->
mterhar
pushed a commit
to mterhar/opentelemetry-collector-contrib
that referenced
this pull request
Dec 19, 2024
… instrumentaion key (open-telemetry#36794) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Fixed not exporting to azure monitor when using instrumentation key without endpoint. If default config is set, it'll never goto the branch https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/ab0f6a24521104e2e06c11673bc462aa4a5703e4/exporter/azuremonitorexporter/connection_string_parser.go#L47 <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36704 <!--Describe what testing was performed and which tests were added.--> #### Testing tested locally and can send metrics/logs/traces to `appinsights` successfully. And passes all tests. <!--Describe the documentation added.--> #### Documentation no need to update. <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed not exporting to azure monitor when using instrumentation key without endpoint. If default config is set, it'll never goto the branch
opentelemetry-collector-contrib/exporter/azuremonitorexporter/connection_string_parser.go
Line 47 in ab0f6a2
Link to tracking issue
Fixes #36704
Testing
tested locally and can send metrics/logs/traces to
appinsightssuccessfully. And passes all tests.Documentation
no need to update.