Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Skip dbstorage extension tests on Windows GH runners #36267

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Nov 7, 2024

Fixes #36212

This is caused by the fact that on Windows GH runners Docker is set to run Windows containers, the test passes on Windows when running Docker is set to run Linux containers. Notice that it consistently leaks a goroutine:

=== RUN   TestExtensionIntegrityWithPostgres
2024/11/07 12:01:04 (1) [] port not found
2024/11/07 12:01:05 (2) [] port not found
2024/11/07 12:01:05 (3) [] port not found
--- PASS: TestExtensionIntegrityWithPostgres (16.42s)
PASS
goleak: Errors on successful test run: found unexpected goroutines:
[Goroutine 20 in state syscall, locked to thread, with syscall.SyscallN on top of the stack:
syscall.SyscallN(0xc00010e298?, {0xc0002a1410?, 0x7ff7b9bdb0c0?, 0xc00010e240?})
        C:/Users/pjanotti/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.0.windows-amd64/src/runtime/syscall_windows.go:544 +0x107
github.com/Microsoft/go-winio.getQueuedCompletionStatus(0x208, 0xc0000a1f8c?, 0xc0000a1f90?, 0xc0000a1f98?, 0xffffffff)
        C:/Users/pjanotti/go/pkg/mod/github.com/!microsoft/go-winio@v0.6.2/zsyscall_windows.go:327 +0xbb
github.com/Microsoft/go-winio.ioCompletionProcessor(0x208)
        C:/Users/pjanotti/go/pkg/mod/github.com/!microsoft/go-winio@v0.6.2/file.go:162 +0x85
created by github.com/Microsoft/go-winio.initIO in goroutine 19
        C:/Users/pjanotti/go/pkg/mod/github.com/!microsoft/go-winio@v0.6.2/file.go:58 +0x5d
]
FAIL    github.com/open-telemetry/opentelemetry-collector-contrib/extension/storage/dbstorage   17.344s

this PR doesn't address the goroutine leak.

@songy23 songy23 added the Run Windows Enable running windows test on a PR label Nov 7, 2024
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase. The unrelated build failures should be fixed with #36266

@djaglowski djaglowski merged commit 65cd1f9 into open-telemetry:main Nov 8, 2024
171 of 174 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 8, 2024
@pjanotti pjanotti deleted the skip-extension-integreity-test-on-win-gh-runner branch November 8, 2024 16:15
pull bot pushed a commit to abaguas/opentelemetry-collector-contrib that referenced this pull request Nov 8, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension/storage Run Windows Enable running windows test on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[extension/dbstorage] Flaky TestExtensionIntegrityWithPostgres
5 participants