parser/keyvalue: handle escaped quotes when parsing #36176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadams41
force-pushed
the
eadams/escaped-quotes-in-keyvalue-parser
branch
from
0a3e582 to
b5342fd
Compare
Currently, the SplitString parser does not handle escaped quotes and instead will parse these as independent '\', '"' characters. This results in unexpected breakages between fields for strings like: > <key>="...\" ..." Here, the backslash will be appended to the result pair, while the (now un-)escaped quotation will result in the pair being terminated early. Add handling of escaped quotation marks (for both ", ') in the keyvalue parser along with a testcase to exercise this functionality. Signed-off-by: Ethan Adams <eadams@netflix.com>
jadams41
force-pushed
the
eadams/escaped-quotes-in-keyvalue-parser
branch
from
b5342fd to
b87144c
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Hello - wondering if there is anything I should be doing to drive this? If this is just pending review, I can bump on a newer |
…-in-keyvalue-parser
djaglowski
approved these changes
Dec 3, 2024
djaglowski
reviewed
Dec 4, 2024
shivanthzen
pushed a commit
to shivanthzen/opentelemetry-collector-contrib
that referenced
this pull request
Dec 5, 2024
…6176) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Currently, the keyvalue parser does handle escaped quotes and instead will parse this as independent '\', '"' characters. This results in unexpected breakages between fields for strings like: > <key>="...\\" ..." Here, the backslash will be appended to the result pair, while the (now un-)escaped quotation will result in the pair being terminated early. Add handling of escaped quotation marks (for both ", ') in the keyvalue parser along with a testcase to exercise this functionality. --------- Signed-off-by: Ethan Adams <eadams@netflix.com> Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
ZenoCC-Peng
pushed a commit
to ZenoCC-Peng/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2024
…6176) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Currently, the keyvalue parser does handle escaped quotes and instead will parse this as independent '\', '"' characters. This results in unexpected breakages between fields for strings like: > <key>="...\\" ..." Here, the backslash will be appended to the result pair, while the (now un-)escaped quotation will result in the pair being terminated early. Add handling of escaped quotation marks (for both ", ') in the keyvalue parser along with a testcase to exercise this functionality. --------- Signed-off-by: Ethan Adams <eadams@netflix.com> Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…6176) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Currently, the keyvalue parser does handle escaped quotes and instead will parse this as independent '\', '"' characters. This results in unexpected breakages between fields for strings like: > <key>="...\\" ..." Here, the backslash will be appended to the result pair, while the (now un-)escaped quotation will result in the pair being terminated early. Add handling of escaped quotation marks (for both ", ') in the keyvalue parser along with a testcase to exercise this functionality. --------- Signed-off-by: Ethan Adams <eadams@netflix.com> Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the keyvalue parser does handle escaped quotes and instead will parse this as independent '', '"' characters. This results in unexpected breakages between fields for strings like:
Add handling of escaped quotation marks (for both ", ') in the keyvalue parser along with a testcase to exercise this functionality.