(connectors/spanmetricsconnector): Spanmetrics Connector, move starttimestamps from root-level span to child-level spans #36019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivanthzen
added a commit
to shivanthzen/opentelemetry-collector-contrib
that referenced
this pull request
Nov 4, 2024
… of a metric is currently tied to the root span. When a "new" child span appears for trace (eg : unhappy path on an api call which results in a new subspan or an async process that was triggered much later), the time starttimestamp for the new metric for the new child span is that of the parent span(which can be well in the past). This MR moves the start timestamp from resource level (root span) to metric level(child span) . (Doesn't consider delta-temporality as of now). References: open-telemetry#35994 Upstream Fix: open-telemetry#36019
shivanthzen
added a commit
to shivanthzen/opentelemetry-collector-contrib
that referenced
this pull request
Nov 4, 2024
Currently while generating metrics out of traces, the start timestamp of a metric is currently tied to the root span. When a "new" child span appears for trace (eg : unhappy path on an api call which results in a new subspan or an async process that was triggered much later), the time starttimestamp for the new metric for the new child span is that of the parent span(which can be well in the past). This MR moves the start timestamp from resource level (root span) to metric level(child span) . (Doesn't consider delta-temporality as of now). References: open-telemetry#35994 Upstream Fix: open-telemetry#36019
shivanthzen
changed the title
|
@dashpole Looks like spanmetrics connector is seeking new codeowners as per the weekly report . is there any way to get this expedite the process of getting a review ? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
startimestamps for metrics are stored at resource level. Child spans that occur sparsely or async process that occurs much later also use these starttimestamps which is incorrect. This MR moves the start timestamp (and lastsseen timestamp) from root span level(resource level) to child span level (metric level).
POC for #35994
Link to tracking issue
Fixes #35994
Testing
Documentation