Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/hostmetrics] Fix filesystems scraper behavior when root file system is mounted #36000

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Oct 25, 2024

Description

Do not set the default value of HOST_PROC_MOUNTINFO to respect root_path

Link to tracking issue

Fixes #35990

@atoulme atoulme force-pushed the fix_filesystems_scraping branch from 4ef3de4 to a59fa99 Compare October 25, 2024 16:51
@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Oct 28, 2024
@andrzej-stencel andrzej-stencel merged commit 1d864b6 into open-telemetry:main Oct 30, 2024
168 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 30, 2024
zzhlogin pushed a commit to zzhlogin/opentelemetry-collector-contrib-aws that referenced this pull request Nov 12, 2024
…e system is mounted (open-telemetry#36000)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Do not set the default value of HOST_PROC_MOUNTINFO to respect root_path

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#35990
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…e system is mounted (open-telemetry#36000)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Do not set the default value of HOST_PROC_MOUNTINFO to respect root_path

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#35990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/hostmetrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/hostmetrics] filesystem scraper doesn't respect root_path
7 participants