Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/solacereceiver]: Fix for receiver unexpectedly terminating on reporting traces when used with a memory limiter processor and under high load #35958

Merged

Conversation

oodigie
Copy link
Contributor

@oodigie oodigie commented Oct 23, 2024

Description: The Solace receiver may unexpectedly terminate on reporting traces when used with a memory limiter processor and under high load.

Link to tracking Issue: N/A

Testing: N/A

Documentation: N/A

@atoulme
Copy link
Contributor

atoulme commented Oct 23, 2024

Please run make for-all-target=gofmt to fix the formatting and unintended touched files.

@atoulme
Copy link
Contributor

atoulme commented Oct 23, 2024

alternatively, make generate should also run fmt.

@oodigie
Copy link
Contributor Author

oodigie commented Oct 23, 2024

@atoulme, this is surprising because I actually ran make generate and that was what generated the unintended file changes. Let me run it again.

@oodigie
Copy link
Contributor Author

oodigie commented Oct 23, 2024

@atoulme, there was an issue was with the go version format in the pkg/kafka/topic/go.mod which was set to go 1.22 instead of the project wide go 1.22.0 so it broke make generate. I updated it and ran generate again and everything looks good now. Thanks

@djaglowski djaglowski merged commit 2ec4906 into open-telemetry:main Oct 24, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 24, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…on reporting traces when used with a memory limiter processor and under high load (open-telemetry#35958)

**Description:** The Solace receiver may unexpectedly terminate on
reporting traces when used with a memory limiter processor and under
high load.

**Link to tracking Issue:** N/A

**Testing:** N/A

**Documentation:** N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/telemetrygen telemetrygen command connector/count connector/exceptions connector/failover connector/grafanacloud connector/otlpjson connector/roundrobin connector/routing connector/servicegraph connector/spanmetrics connector/sum exporter/alertmanager exporter/awscloudwatchlogs awscloudwatchlogs exporter exporter/awskinesis exporter/awss3 exporter/azuredataexplorer exporter/carbon exporter/cassandra exporter/clickhouse exporter/coralogix exporter/doris exporter/elasticsearch exporter/file exporter/googlecloud exporter/googlemanagedprometheus Google Managed Prometheus exporter exporter/honeycombmarker exporter/influxdb exporter/kafka exporter/kinetica exporter/loadbalancing exporter/logicmonitor exporter/logzio exporter/loki Loki Exporter exporter/mezmo exporter/opencensus exporter/opensearch exporter/otelarrow exporter/prometheus exporter/prometheusremotewrite exporter/pulsar exporter/rabbitmq exporter/sapm exporter/sentry exporter/signalfx exporter/splunkhec exporter/sumologic exporter/syslog exporter/zipkin extension/ack extension/basicauth extension/bearertokenauth extension/encoding extension/googleclientauth extension/headerssetter extension/healthcheck Health Check Extension extension/healthcheckv2 extension/httpforwarder extension/jaegerremotesampling extension/oauth2clientauth extension/observer extension/oidcauth extension/opamp extension/pprof extension/remotetap extension/sigv4auth extension/solarwindsapmsettings extension/storage extension/sumologic pkg/golden pkg/kafka/topic receiver/solace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants