[receiver/hostmetrics] register scrapers with scraper names #35837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes each scraper's factory to create a scraper with the scraper's name. This is to ensure that logs from the `scrapercontroller` will contain the name of the scraper.
atoulme
approved these changes
Oct 17, 2024
pjanotti
approved these changes
Oct 17, 2024
pjanotti
added
the
ready to merge
dmitryax
approved these changes
Oct 24, 2024
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…emetry#35837) #### Description This PR changes each scraper's factory to create a scraper with the scraper's name. This is to ensure that logs from the `scrapercontroller` will contain the name of the scraper. #### Link to tracking issue Fixes open-telemetry#35814 #### Testing New unit tests Built the collector with `cpu` scraper modified to immediately return an error and got the following message: ``` 2024-10-16T14:58:46.396Z error scraperhelper/scrapercontroller.go:205 Error scraping metrics {"kind": "receiver", "name": "hostmetrics", "data_type": "metrics", "error": "hi i failed", "scraper": "cpu"} ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes each scraper's factory to create a scraper with the scraper's name. This is to ensure that logs from the
scrapercontrollerwill contain the name of the scraper.Link to tracking issue
Fixes #35814
Testing
New unit tests
Built the collector with
cpuscraper modified to immediately return an error and got the following message:Documentation
Not needed.