Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace @ycombinator with @lahsivjar as codeowner for elasticsearchexporter #35322

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ycombinator
Copy link
Contributor

Description:

This PR replaces @ycombinator with @lahsivjar as one of the codeowners for the elasticsearchexporter component.

Over the past few months, @lahsivjar has been a far more active contributor to this component than @ycombinator.

@ycombinator ycombinator requested a review from a team as a code owner September 20, 2024 14:00
@andrzej-stencel andrzej-stencel added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 20, 2024
@andrzej-stencel
Copy link
Member

@ycombinator This change needs to be done https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/elasticsearchexporter/metadata.yaml. The CODEOWNERS file is generated from the metadata files.

@carsonip
Copy link
Contributor

+1 on the proposal. Thank @ycombinator and @lahsivjar

@ycombinator
Copy link
Contributor Author

@ycombinator This change needs to be done https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/elasticsearchexporter/metadata.yaml. The CODEOWNERS file is generated from the metadata files.

Thanks @andrzej-stencel for pointing that out. Done in c008817.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ycombinator, just waiting for a ✅ from @lahsivjar

@crobert-1
Copy link
Member

From failing CI check:

Generated code is out of date, please run "make generate" and commit the changes in this PR.

This will update the exporter's README to include the updated code owners 👍

Copy link
Member

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ycombinator!

@ycombinator
Copy link
Contributor Author

Thanks @ycombinator!

No, thank you for taking this on!

@ycombinator
Copy link
Contributor Author

ycombinator commented Sep 20, 2024

From failing CI check:

Generated code is out of date, please run "make generate" and commit the changes in this PR.

This will update the exporter's README to include the updated code owners 👍

Thanks @crobert-1. Done in c651f6b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/elasticsearch Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants