[chore] Fix "Device or resource busy" error on Windows CI #35192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
approved these changes
Sep 16, 2024
crobert-1
approved these changes
Sep 16, 2024
pjanotti
deleted the
fix-windows-ci-intermittent-error-device-or-resource-busy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The error "Device or resource busy" happens intermittently when running the
build-and-test-windowsworkflow on CI. Examining a few instances of the error it becomes clear that the concurrent run of component tests trigger concurrent builds ofgotestsum. This can cause one of the runs to clash with the other and fail to build thegotestsumtarget.The fix is to add a explicit step to build
gotestsumin the CI workflow. This way the local dev modus operandi is not altered (they can still rely onmake testto build any tool necessary for the test). If any other tools are added to thetesttarget they should also be added to the workflow on Windows.Link to tracking Issue:
Fix #34691
Testing:
Validated on repository fork.
Documentation:
N/A