[exporter/datadogexporter] Add support for custom log source #35051
Conversation
This PR updates `github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/logsagentexporter` to include commit: DataDog/datadog-agent@09b07eb. This adds support for setting a custom log source from resource attribute or log attribute `datadog.log.source`.
github-actions
bot
added
cmd/otelcontribcol
github-actions
bot
requested review from
ankitpatel96,
dineshg13 and
liustanley
exporter/datadogexporter/README.md
Outdated
|
|
||
| ### How to add custom log source | ||
|
|
||
| In order to add a custom source to your OTLP logs, set log attribute or resource attribute `datadog.log.source`. |
There was a problem hiding this comment.
It's unusual to support an attribute both as a log attribute and a resource attribute (I don't know of any examples from semantic conventions at least). Why are we doing it like this?
There was a problem hiding this comment.
I agree with you, and ideally this would be read only from resource attributes. It's currently done this way due to how the logs code is structured. The origin is accessible here, and this is where we need to set the source.
At this point, the attributes and resource attributes have been merged and are not distinguishable within AdditionalProperties. See Attributes/ resource attributes.
We have the same issue with status. This is fixable, but requires a refactor of the logs code to allow this.
There was a problem hiding this comment.
As discussed offline, will create a card to refactor logs path, and in the meantime will remove support for log attributes from docs.
…lemetry#35051) **Description:** This PR updates `github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/logsagentexporter` to include commit: DataDog/datadog-agent@09b07eb. This adds support for setting a custom log source from resource attribute or log attribute `datadog.log.source`. **Link to tracking Issue:** <Issue number if applicable> **Testing:** Tested this locally by sending logs with attribute `datadog.log.source` and ensuring this was used as the source. **Documentation:** Updated datadog exporter README.
…lemetry#35051) **Description:** This PR updates `github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/logsagentexporter` to include commit: DataDog/datadog-agent@09b07eb. This adds support for setting a custom log source from resource attribute or log attribute `datadog.log.source`. **Link to tracking Issue:** <Issue number if applicable> **Testing:** Tested this locally by sending logs with attribute `datadog.log.source` and ensuring this was used as the source. **Documentation:** Updated datadog exporter README.
Description:
This PR updates
github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/logsagentexporterto include commit: DataDog/datadog-agent@09b07eb. This adds support for setting a custom log source from resource attribute or log attributedatadog.log.source.Link to tracking Issue:
Testing: Tested this locally by sending logs with attribute
datadog.log.sourceand ensuring this was used as the source.Documentation: Updated datadog exporter README.