(otelarrowexporter): Create exporter per unique value of configured metadataKeys #34827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moh-osman3
changed the title
moh-osman3
force-pushed
the
mohosman/arrow-exporter-by-metadata
branch
2 times, most recently
from
66be2e2 to
957af76
Compare
jmacd
requested changes
Aug 26, 2024
jmacd
requested changes
Aug 26, 2024
jmacd
reviewed
Aug 26, 2024
jmacd
approved these changes
Aug 27, 2024
jmacd
approved these changes
Sep 5, 2024
mwear
approved these changes
Sep 5, 2024
mwear
added
the
ready to merge
jmacd
approved these changes
Sep 9, 2024
|
I merged another otelarrow PR that created a conflict here, could you take a look? |
mx-psi
removed
the
ready to merge
moh-osman3
force-pushed
the
mohosman/arrow-exporter-by-metadata
branch
from
6c15335 to
a513619
Compare
|
@mx-psi Rebased this PR to fix conflicts - would you mind reviewing again please? |
jmacd
requested changes
Sep 12, 2024
moh-osman3
force-pushed
the
mohosman/arrow-exporter-by-metadata
branch
from
a513619 to
245ab96
Compare
moh-osman3
force-pushed
the
mohosman/arrow-exporter-by-metadata
branch
2 times, most recently
from
8e444d6 to
29c276c
Compare
moh-osman3
force-pushed
the
mohosman/arrow-exporter-by-metadata
branch
from
29c276c to
70295ea
Compare
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
moh-osman3
force-pushed
the
mohosman/arrow-exporter-by-metadata
branch
from
70295ea to
32b9cb6
Compare
jmacd
approved these changes
Sep 18, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…etadataKeys (open-telemetry#34827) **Description:** This PR forks open-telemetry#34235 and adds unit tests. **Link to tracking Issue:** open-telemetry#34178 --------- Co-authored-by: kristina.pathak <kristina.m.pathak@gmail.com> Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR forks #34235 and adds unit tests.
Link to tracking Issue:
#34178